Bug 2332078
| Summary: | Review Request: python-markdown-callouts - Markdown extension to provide a classier syntax for admonitions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> | ||||
| Component: | Package Review | Assignee: | Michel Lind <michel> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | michel, package-review | ||||
| Target Milestone: | --- | Flags: | michel:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://oprypin.github.io/markdown-callouts | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-12-13 12:01:47 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2332084 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Davide Cavalca
2024-12-12 14:21:25 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=126755896 Copr build: https://copr.fedorainfracloud.org/coprs/build/8384636 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332078-python-markdown-callouts/fedora-rawhide-x86_64/08384636-python-markdown-callouts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. - I'll call the bcond flag tests instead of checks - since it's confusing, you do have a check section - Run the import check unconditionally, there is no reason not to Will try and see why the tests fail pyproject.toml lists an extra dependency on pytest-golden, which I don't see packaged. Update the comment about why tests are not run, and/or package this? (I suspect we'll have to disable tests in EPEL because packaging this might bring in many dependencies, but this will help if we want to reenable tests in Fedora sometime) Spec URL: https://dcavalca.fedorapeople.org/review/python-markdown-callouts/python-markdown-callouts.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-markdown-callouts/python-markdown-callouts-0.4.0-1.fc42.src.rpm Changelog: - rename bcond - fix the tests Created attachment 2062182 [details]
The .spec file difference from Copr build 8384636 to 8384732
Copr build: https://copr.fedorainfracloud.org/coprs/build/8384732 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332078-python-markdown-callouts/fedora-rawhide-x86_64/08384732-python-markdown-callouts/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with pyp2spec, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the sotware is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with the Python Packaging Guidelines Package APPROVED. === Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`: - add @python-packagers-sig with "commit" access as package co-maintainer - track package in koschei for all built branches The Pagure repository was created at https://src.fedoraproject.org/rpms/python-markdown-callouts FEDORA-2024-7e6c3bfb8d (python-markdown-callouts-0.4.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7e6c3bfb8d FEDORA-2024-7e6c3bfb8d (python-markdown-callouts-0.4.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |