Bug 2332084
| Summary: | Review Request: python-pytest-golden - Plugin for pytest that offloads expected outputs to data files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | michel, package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://github.com/oprypin/pytest-golden | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-12-13 11:43:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2332078 | ||
|
Description
Davide Cavalca
2024-12-12 14:55:44 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=126756741 Copr build: https://copr.fedorainfracloud.org/coprs/build/8384730 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332084-python-pytest-golden/fedora-rawhide-x86_64/08384730-python-pytest-golden/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Nit: please run %pytest -v instead of %pytest because it looks like upstream does not configure the tests to run verbosely by default (so we don't see a list of tests being run) Package was generated with pyp2spec, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the sotware is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with the Python Packaging Guidelines Package APPROVED. === Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`: - add @python-packagers-sig with "commit" access as package co-maintainer - track package in koschei for all built branches The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-golden FEDORA-2024-0c545848a1 (python-pytest-golden-0.2.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0c545848a1 FEDORA-2024-0c545848a1 (python-pytest-golden-0.2.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |