Bug 233242
| Summary: | Review Request: ragel - finite state machine compiler | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeremy Hinegardner <jeremy> |
| Component: | Package Review | Assignee: | Jochen Schmitt <jochen> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | jochen:
fedora-review+
wtogami: fedora-cvs+ |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-03-24 18:49:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jeremy Hinegardner
2007-03-21 06:22:44 UTC
Good: + Naming seems ok. + Tar ball matches with upstream. + Local build works fine. * Rpmlint quite on source rpm. + Rpmlint quite on binary rpm. + Rpmlint quite on debugin rpm. + Local install and uninstallworks fine. + Start of programm works without crash. + Mock build works fine. Bad: - Why you have a BuildRequires to autoconf, when you not call autoconf in the build stanza? This is also my first package and I'm seeking a sponsor. I've updated the spec to not have BuildRequires: autoconf. Not sure why I had that, bit of a mistake. New Spec and src rpm available. Spec URL: http://www.hinegardner.org/fedora-extras/ragel.spec SRPM URL: http://www.hinegardner.org/fedora-extras/ragel-5.19-1.src.rpm Note: Please increase the release number if you create a new rpm package. Good: + License OK. + Autoconf was removed from BR. ** APPROVED ** A new upload with the appropriately incremented relase number is available Spec URL: http://www.hinegardner.org/fedora-extras/ragel.spec SRPM URL: http://www.hinegardner.org/fedora-extras/ragel-5.19-2.src.rpm Removing FE-NEEDSPONSOR. Submitter was sponsored in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233522 New Package CVS Request ======================= Package Name: ragel Short Description: Finite state machine compiler Owners: jeremy Branches: FC-5 FC-6 InitialCC: |