Bug 233244
Summary: | Review Request: libiptcdata - IPTC Metadata library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Moore <david.moore> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mtasaka |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
wtogami: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-03-27 03:49:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
David Moore
2007-03-21 07:19:22 UTC
First impression * URL - For URL, please use: http://libiptcdata.sourceforge.net/ * Python directory - For python sitelib/arch directory, please refer to http://fedoraproject.org/wiki/Packaging/Python * Release specific dependency - Usually, the dependency for main (and other) package must be release number specific. http://fedoraproject.org/wiki/Packaging/ReviewGuidelines * Timestamps - Please keep timestamps on the files which are not created at build time (i.e. which are included in the original tarball and not modified at build time) (for example, header files in -devel package). For this package, the following works. ------------------------------------------------ make DESTDIR=%{buildroot} INSTALL="%{__install} -c -p" install ------------------------------------------------ * Documentation - File "INSTALL" should not be needed. This is for who want to install this package by themselves. Okay, thanks for the critique. I have updated the links above with the new package and specfile that fixes the issues you have pointed out. Oh, I didn't realize you updated the spec/srpm... Then: * http://fedoraproject.org/wiki/Packaging/FrequentlyMadeMistakes ------------------------------------------------------- Increase the "Release" tag every time you upload a new package to avoid confusion. The reviewer and other interested parties probably still have older versions of your SRPM lying around to check what has changed between the old and new packages; those get confused when the revision didn't change. ------------------------------------------------------- Okay, fixed: Spec URL: http://pisces.mit.edu/~dcm/packages/libiptcdata.spec SRPM URL: http://pisces.mit.edu/~dcm/packages/libiptcdata-1.0.0-2.src.rpm Well, for 1.0.0-2: * Documentation - The following documents are not encoded with UTF-8. Please change the encoding to UTF-8. ----------------------------------------------------- /usr/share/doc/libiptcdata-1.0.0/README ----------------------------------------------------- Other things are okay. Then: ----------------------------------------------------- NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora Extras package review requests which are waiting for someone to review can be checked on: https://bugzilla.redhat.com/bugzilla/buglist.cgi?cmdtype=runnamed&namedcmd=mtasaka-review-noone NOTE: FE-NEW blockers are now not complete. Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ------------------------------------------------------------ Okay, thanks. Package is updated here, also with a new upstream version (which includes the README fix along with other upstream changes): Spec URL: http://pisces.mit.edu/~dcm/packages/libiptcdata.spec SRPM URL: http://pisces.mit.edu/~dcm/packages/libiptcdata-1.0.1-1.src.rpm I will find another package to submit or pre-review to continue the sponsorship process. I have done a "pre-review" of bug 233691 I have done another pre-review, this time for bug 233695 Well, * This package is okay * For pre-reviewing, some points seems overlooked, however I expect that you can get skilled in reviewing. ----------------------------------------------- This package (libiptcdata) is APPROVED by me. ----------------------------------------------- I will sponsor you. Please follow: http://fedoraproject.org/wiki/PackageMaintainers/Join Welcome to Fedora!! New Package CVS Request ======================= Package Name: libiptcdata Short Description: IPTC tag library Owners: dcm Branches: FC-5 FC-6 InitialCC: Built in FC-5, FC-6, devel. Thanks Mamoru and others! Package Change Request ====================== Package Name: libiptcdata New Branches: EL-4 EL-5 |