Bug 2332609

Summary:	Review Request: rust-mdbook - Creates a book from markdown files
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	NEW ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/mdbook
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2332598
Bug Blocks:

Description Fabio Valentini 2024-12-16 17:20:45 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-mdbook.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-mdbook-0.4.40-1.fc41.src.rpm

Description:
Creates a book from markdown files.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2024-12-16 17:23:15 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8398363
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332609-rust-mdbook/fedora-rawhide-x86_64/08398363-rust-mdbook/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-12-16 17:27:39 UTC

I tried my best to correctly document the bundled components (JavaScript, fonts, CSS, etc.).

Note that the bundled JavaScript libraries are BSD-3-Clause or MIT licensed, but no license texts for these two licenses are included (other than the one included in the ace.js file for ace.js itself). Should the upstream project include the upstream license texts for these bundled components? They *do* include the license texts for the bundled fonts (Open Sans and Source Code Pro), so there would be precedent for doing so. I'm not sure how this should be handled.

I looked into whether it would be possible to un-bundle the fonts, but it looks like they're embedded in a format (WOFF2) that is not included in the Fedora packages anyway.

Comment 3 Fabio Valentini 2024-12-16 17:29:42 UTC

Second note: I packaged 0.4.40 intentionally, since 0.4.41+ bump dependencies past what we have in Fedora (notably, handlebars v5 -> v6).

Comment 4 Fabio Valentini 2025-03-15 22:58:47 UTC

Dropping the (for now, problematic) dependency on the "select" crate is straightforward, since it is only used in a single file of integration tests. I have done so for now, until problems with "select" can be dealt with.