Bug 2332930

Summary: Please branch and build rust-pyo3_0.20 in epel10
Product: [Fedora] Fedora EPEL Reporter: Romain Geissler <romain.geissler>
Component: rust-pyo3_0.20Assignee: Rust SIG <rust-sig>
Status: CLOSED WONTFIX QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel10CC: decathorpe, rust-sig
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-12-25 18:20:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2319805    

Description Romain Geissler 2024-12-17 22:20:03 UTC
Hi,

Please branch and build rust-pyo3_0.20 in epel10, it is a dependency of python-libcst.

Cheers,
Romain

Comment 1 Fabio Valentini 2024-12-18 00:02:40 UTC
I would prefer not to branch more pyo3 compat packages for epel10 (other than the packages for v0.23 and v0.22 that are already there).
Old versions of pyo3 like v0.20 don't even officially support recent versions of Python.

Comment 2 Romain Geissler 2024-12-18 14:06:48 UTC
That is also my wish. As far as libcst is concerned, this will need to wait that https://github.com/Instagram/LibCST/pull/1180 is merged upstream (as I doubt on Fedora side we do apply patch before these are accepted upstream, do we ?).

Comment 3 Fabio Valentini 2024-12-18 14:12:39 UTC
Adding patches downstream before they are merged upstream isn't that uncommon.

As far as I can tell, the PR for updating to pyo3 v0.22 looks good and passed upstream CI.

In this case, I would recommend asking the python-libcst maintainer to apply this patch downstream, so we can avoid branching pyo3 v0.20 for epel 10.

Comment 4 Romain Geissler 2024-12-25 17:15:19 UTC
Ok, I have backported to pyo 0.22 upgrade in this pull request: https://src.fedoraproject.org/rpms/python-libcst/pull-request/6

If all the rust-peg packages are built, with the above pull request I can successfully build python-libcst for EPEL 10.

Comment 5 Fabio Valentini 2024-12-25 18:20:24 UTC
Thanks, the PR looks good to me. Knowing the maintainers of python-libcst (they are both also Rust SIG members), I assume the PR will get merged.