Bug 2332971

Summary: Review Request: python-csscompressor - Python port of YUI CSS Compressor
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/sprymix/csscompressor
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-12-20 06:22:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2332973    

Description Davide Cavalca 2024-12-18 08:08:26 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/python-csscompressor/python-csscompressor.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/python-csscompressor/python-csscompressor-0.9.5-1.fc42.src.rpm

Description:
This package is an almost exact port of YUI CSS Compressor to Python that
passes all the original unittests.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-12-18 08:08:30 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=126977454

Comment 2 Fedora Review Service 2024-12-18 08:12:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8406746
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332971-python-csscompressor/fedora-rawhide-x86_64/08406746-python-csscompressor/fedora-review/review.txt

Found issues:

- python3-pytest7 is deprecated, you must not depend on it.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2024-12-20 03:28:56 UTC
Package was generated with pyp2spec, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the sotware is packaged
- license matches upstream specification (BSD-3-Clause) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with the Python Packaging Guidelines

Package APPROVED.

===

Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`:

- add @python-packagers-sig with "commit" access as package co-maintainer

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2024-12-20 06:09:30 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-csscompressor

Comment 5 Fedora Update System 2024-12-20 06:17:55 UTC
FEDORA-2024-6849a10b79 (python-csscompressor-0.9.5-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6849a10b79

Comment 6 Fedora Update System 2024-12-20 06:22:49 UTC
FEDORA-2024-6849a10b79 (python-csscompressor-0.9.5-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.