Bug 2332972
| Summary: | Review Request: python-htmlmin2 - Configurable HTML Minifier with safety features | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | michel, package-review, tjuhasz |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://github.com/wilhelmer/htmlmin | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-12-20 06:19:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2332973 | ||
|
Description
Davide Cavalca
2024-12-18 08:28:00 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=126978023 Copr build: https://copr.fedorainfracloud.org/coprs/build/8406759 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332972-python-htmlmin2/fedora-rawhide-x86_64/08406759-python-htmlmin2/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hello, I have few suggestion for improving your specfile, just informal, I'm not a maintainer. According to the python guideline:https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ If is not possible to use the upstream install method:, you should use BuildRequires: python3dist(pytest) Use of multiple licenses should be explicitly defined for all files: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines I think python3-pytest and python3dist(pytest) are equivalent, it's not a big deal either way. and the file that is under Python 2.0.1 license is specified in the comment so it's fine Package was generated with pyp2spec, simplifying the review. Package was unretired and the diff from the previous spec (FXX) is reasonable, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the sotware is packaged - license matches upstream specification (BSD-3-Clause AND Python-2.0.1) and is acceptable for Fedora - license file is included with %license in %files - package complies with the Python Packaging Guidelines Package APPROVED. === Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`: - add @python-packagers-sig with "commit" access as package co-maintainer - track package in koschei for all built branches The Pagure repository was created at https://src.fedoraproject.org/rpms/python-htmlmin2 FEDORA-2024-de7db82619 (python-htmlmin2-0.1.13-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-de7db82619 FEDORA-2024-de7db82619 (python-htmlmin2-0.1.13-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |