Bug 2332973

Summary:	Review Request: python-mkdocs-minify-plugin - MkDocs plugin to minify HTML, JS or CSS files
Product:	[Fedora] Fedora	Reporter:	Davide Cavalca <davide>
Component:	Package Review	Assignee:	Michel Lind <michel>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	michel, package-review
Target Milestone:	---	Flags:	michel: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://github.com/byrnereese/mkdocs-minify-plugin
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-12-21 07:46:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2332971, 2332972
Bug Blocks:	2333298

Description Davide Cavalca 2024-12-18 08:28:25 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/python-mkdocs-minify-plugin/python-mkdocs-minify-plugin.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/python-mkdocs-minify-plugin/python-mkdocs-minify-plugin-0.8.0-1.fc42.src.rpm

Description:
This package provides an MkDocs plugin to minify HTML, JS or CSS files prior to
being written to disk. HTML minification is done using htmlmin2. JS
minification is done using jsmin. CSS minification is done using
csscompressor.

Fedora Account System Username: dcavalca

Comment 1 Fedora Review Service 2024-12-18 08:30:32 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8406760
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332973-python-mkdocs-minify-plugin/fedora-rawhide-x86_64/08406760-python-mkdocs-minify-plugin/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Michel Lind 2024-12-20 21:33:34 UTC

Package was generated with pyp2spec, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the sotware is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with the Python Packaging Guidelines

Package APPROVED.

===

Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`:

- add @python-packagers-sig with "commit" access as package co-maintainer

- track package in koschei for all built branches

Comment 3 Fedora Admin user for bugzilla script actions 2024-12-21 07:32:50 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mkdocs-minify-plugin

Comment 4 Fedora Update System 2024-12-21 07:42:26 UTC

FEDORA-2024-6df4a90b1d (python-mkdocs-minify-plugin-0.8.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6df4a90b1d

Comment 5 Fedora Update System 2024-12-21 07:46:49 UTC

FEDORA-2024-6df4a90b1d (python-mkdocs-minify-plugin-0.8.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.