Bug 233324
Summary: | resync option to cmirrors needs to error out if volume is active | ||
---|---|---|---|
Product: | [Retired] Red Hat Cluster Suite | Reporter: | Corey Marthaler <cmarthal> |
Component: | lvm2-cluster | Assignee: | Jonathan Earl Brassow <jbrassow> |
Status: | CLOSED NOTABUG | QA Contact: | Cluster QE <mspqa-list> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 4 | CC: | agk, ccaulfie, dwysocha, jbrassow, mbroz, prockai |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-07-24 10:41:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Corey Marthaler
2007-03-21 16:27:29 UTC
I'm not sure that it's worth changing that. Since it seems normal deactivation ('lvchange -an') works without a need of exclusive access, I'm afraid relationship between the messages "Do you really want to deactivate..?" and "Can't get exclusive access.." is not clear to the user. How about skipping exclusive-activation or change the message to encourage 'lvchange -an' manually? Current code sequence is this: ----------------------------------- if (active) { ask "Do you really want to deactivate?" if (not yes) { return failed } } if (cluster) { if (!activate_lv_excl) { return failed } } deactivate_lv ----------------------------------- What if we do this? ----------------------------------- if (active) { ask "Do you really want to deactivate?" if (not yes) { return failed } } else if (cluster) { if (!activate_lv_excl) { return failed } } deactivate_lv ----------------------------------- I think activate_lv_excl in this case is necessary to make the activeness test and deactivate_lv atomic. (To prevent other node activates the lv between them.) If it's the only reason of activate_lv_excl, can we just deactivate it if the user said he really want to so? Same discussion might be applied to lvremove. Is the volume mounted on a remote node? If so, I think it's doing the right thing. It's saying "you've asked to deactivate this volume, but it's in-use on another node! Too bad for you." I'm closing this NOTABUG. Feel free to reopen if the volume was not mounted on another node (or if you feel strongly about what error messages should be printed). I think it's doing the right thing. |