Bug 233352
| Summary: | Review Request: funtools - FITS library and utilities | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sergio Pascual <sergio.pasra> | ||||||
| Component: | Package Review | Assignee: | Jochen Schmitt <jochen> | ||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | mtasaka | ||||||
| Target Milestone: | --- | Flags: | jochen:
fedora-review+
kevin: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2007-03-27 14:47:43 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Sergio Pascual
2007-03-21 19:26:36 UTC
Created attachment 150626 [details]
log file from local build
God: + Naming seems ok. + Tar ball matches with upstream. Bad: - Local build fails, please see attached build.log It has to be a problem with the x86_64 arch, because I tested that it builds in mock, but only for i386. Could you test if this new version builds? I have added some minor fixes. http://t-rex.fis.ucm.es/~spr/funtools.spec http://t-rex.fis.ucm.es/~spr/funtools-1.3.0-0.2.b29.fc6.src.rpm Created attachment 150683 [details]
build log from local build
It's seem not to bee an x64 specific problem.
(In reply to comment #4) > Created an attachment (id=150683) [edit] > build log from local build > > It's seem not to bee an x64 specific problem. Looks like a parallel make problem. Not always reproducible for me, however one time mockbuild failed with -j4. What happens if you drop parallel make support (i.e. delete %{?_smp_mflags})? Yes, the problem is there. I have tested the srpm with multiprocessor machines and I get the same failed build. This is the rpm with the parallel make flag removed http://t-rex.fis.ucm.es/~spr/funtools.spec http://t-rex.fis.ucm.es/~spr/funtools-1.3.0-0.3.b29.fc6.src.rpm Good: + Local build works fine. + Rpmlint quite on source rpm. + Rpmlint quite on binary rpm. + Rpmlint quite on Debuginfo rpm. + License Ok. + Package contains verbartin copy of the license. + Mock build works fine. Bad: - Rpmlint complaints installed package: rpmlint funtools W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 sqrt W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_GetStringFromObj W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_ResetResult W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_CreateObjCommand W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 gzopen W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 gzclose W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_SetStringObj W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_GetObjResult W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_PkgProvide Please forward this problem to the upstream author. - rpmlint funtools W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 sqrt W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_GetStringFromObj W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_ResetResult W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_CreateObjCommand W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 gzopen W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 gzclose W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_SetStringObj W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_GetObjResult W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_PkgProvide Thats Ok, becouse package has problem with parallel build. Please forward this problem to the upstream. - Please put a comment on the SPEC file, that parallel build won't works. *** APPROVED *** (In reply to comment #7) [...] > W: funtools undefined-non-weak-symbol /usr/lib64/libtclfun.so.1.0 Tcl_PkgProvide > Thats Ok, becouse package has problem with parallel build. What does parallel build have to do with undefined non-weak symbols in the first place, and why would a broken parallel build make them acceptable? Nothing, Perhaps I have wrote the issues in an unclearly manner. Hello, this new version of the rpm: http://t-rex.fis.ucm.es/~spr/funtools.spec http://t-rex.fis.ucm.es/~spr/funtools-1.3.0-0.4.b29.fc6.src.rpm makes the warnings disappear. I have commented the issue with parallel make inside the spec file and I will communicate it to upstream. New Package CVS Request ======================= Package Name: fntools Short Description: FITS library and utilities Owners: spr.ucm.es Branches: FC-5 FC-6 InitialCC: done (with corrected package name) Package Change Request ====================== Package Name: funtools New Branches: EL-5 cvs done. |