Bug 233388
| Summary: | Review Request: perl-Gtk2-Ex-CalendarButton - Gtk2::Ex::CalendarButton Perl module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lxtnow |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Gtk2-Ex-CalendarButton/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-08-18 19:18:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Chris Weyl
2007-03-22 00:09:45 UTC
Got make test failed in Mock build with
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/00-load....Gtk-WARNING **: cannot open display: at
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/Gtk2.pm line 63.
dubious
Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 1
Failed 1/1 tests, 0.00% okay
t/test.1.....Gtk-WARNING **: cannot open display: at
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/Gtk2.pm line 63.
dubious
Test returned status 1 (wstat 256, 0x100)
t/test.2.....Gtk-WARNING **: cannot open display: at
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/Gtk2.pm line 63.
dubious
Test returned status 1 (wstat 256, 0x100)
t/test.3.....Gtk-WARNING **: cannot open display: at
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/Gtk2.pm line 63.
dubious
Test returned status 1 (wstat 256, 0x100)
Failed Test Stat Wstat Total Fail Failed List of Failed
-------------------------------------------------------------------------------
t/00-load.t 1 256 1 2 200.00% 1
t/test.1.t 1 256 ?? ?? % ??
t/test.2.t 1 256 ?? ?? % ??
t/test.3.t 1 256 ?? ?? % ??
Failed 4/4 test scripts, 0.00% okay. 1/1 subtests failed, 0.00% okay.
make: *** [test_dynamic] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.5961 (%check)
Same issue as with perl-Gtk2-Ex-Carp, I'm afraid: tests bombing on lack of $DISPLAY. New spec/srpm to follow... SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-CalendarButton-0.01-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-CalendarButton.spec Description: I realized that I was constantly re-creating a simple widget that will pop-up and Gtk2::Calendar when clicked. Just like the datetime display on your desktop taskbar. This package is my attempt to extract the portion of code required to create a button-click-calender. New spec/srpm posted. BR as perl is not needed. BR perl is optional. What with the recent (well, ongoing, really) perl/perl-devel split I'm starting to be a touch more pedantic w.r.t. perl BR's. ping? Why isn't this ticket assigned to anyone? I don't think Parag even saw the ping as he's not even in the CC list for this ticket. (In reply to comment #7) > Why isn't this ticket assigned to anyone? I don't think Parag even saw the ping > as he's not even in the CC list for this ticket. Good question :) Fixing... Good to add examples directory under %doc oops sorry wrong comment. Ignore above comment plz now with new License Changes, you need to change License tag Note rpmlint now complains: W: perl-Gtk2-Ex-CalendarButton invalid-license GPL+ or Artistic SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-CalendarButton-0.01-3.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-CalendarButton.spec Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 9013466a6dead8c2072e49826e9a7ab7 Gtk2-Ex-CalendarButton-0.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs nothing + Provides: perl(Gtk2::Ex::CalendarButton) = 0.01 + Requires: perl(:MODULE_COMPAT_5.8.8) perl(Data::Dumper) perl(Glib) perl(Gtk2) perl(strict) perl(warnings) APPROVED. New Package CVS Request ======================= Package Name: perl-Gtk2-Ex-CalendarButton Short Description: Gtk2::Ex::CalendarButton Perl module Owners: cweyl.edu Branches: FC-6, F-7, devel InitialCC: fedora-perl-devel-list http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure The format for these requests has changed. Please see. New Package CVS Request ======================= Package Name: perl-Gtk2-Ex-CalendarButton Short Description: Gtk2::Ex::CalendarButton Perl module Owners: cweyl Branches: FC-6 F-7 InitialCC: Cvsextras Commits: yes InitialCC should be to fedora-perl-devel-list, but I'm not sure how to specify that anymore... cvs done. The perl list can be added with a cc to 'perl-sig' (which I have done here). Thanks Kevin! Added a note about that to PackagingDrafts/Perl, too. Thanks for the review, Parag :) Imported, built, and push request made. |