Bug 2334082
| Summary: | Review Request: rocjpeg - A high-performance jpeg decode library for AMD’s GPUs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom.Rix | ||||
| Component: | Package Review | Assignee: | Jeremy Newton <alexjnewt> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | alexjnewt, package-review, rocm-packagers-sig | ||||
| Target Milestone: | --- | Flags: | alexjnewt:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/ROCm/rocJPEG | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-04-04 14:47:55 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2335650 | ||||||
| Attachments: |
|
||||||
|
Description
Tom.Rix
2024-12-25 16:16:24 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8447374 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334082-rocjpeg/fedora-rawhide-x86_64/08447374-rocjpeg/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. So it seems like you copied a lot of this from rocdecode, which is fine, but you should update it a bit. E.g.: - I noticed that the line mentioning that rocdecode pull > Allow overriding CMAKE_CXX_COMPILER: is probably not applicable in the develop branch because of: https://github.com/ROCm/rocJPEG/commit/4e78bca06adcce207dab336853f26af4d7dad036 Since it now only sets it if the value isn't already set. You can just mention it's resolved upstream instead of putting that link. - For the find libva issue, you can either drop the link to that rocDecode issue link or just note this is a similar issue to that issue. It seems like Also I noticed: > [ ]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > Note: Arch-ed rpms have a total of 4577280 bytes in /usr/share Not sure what is considered "large" but 4.5 mb is probably fine. Nothing else stood out to me, we can probably push it through if you update the above. Spec URL: https://trix.fedorapeople.org/rocjpeg.spec SRPM URL: https://trix.fedorapeople.org/rocjpeg-6.3.1-1.fc42.src.rpm I cleaned up the comments and fixed the whitespace issue in the spec file. The problems with rocdecode are also the problems with rocjpeg because upstream projects' cmakes are nearly identical, differing only by use of rocDecode vs rocJPEG. Created attachment 2064656 [details]
The .spec file difference from Copr build 8447374 to 8470964
Copr build: https://copr.fedorainfracloud.org/coprs/build/8470964 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334082-rocjpeg/fedora-rawhide-x86_64/08470964-rocjpeg/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good approved The Pagure repository was created at https://src.fedoraproject.org/rpms/rocjpeg |