Bug 2334524

Summary:	ics_diff fails with "NameError: name 'readOne' is not defined"
Product:	[Fedora] Fedora	Reporter:	Tim Landscheidt <tim>
Component:	python-vobject	Assignee:	Pierre-YvesChibon <pingou>
Status:	NEW ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	45	CC:	dan, epel-packagers-sig, pb, pingou
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tim Landscheidt 2024-12-27 15:50:38 UTC

On both Fedora 40 and 41, ics_diff fails with "NameError: name 'readOne' is not defined":

| $ for rel in 40 41; do podman run -it fedora:"$rel" /bin/bash -lc 'dnf install -qy python3-vobject > /dev/null &&
| > curl https://github.com/py-vobject/vobject/raw/refs/heads/master/test_files/simple_test.ics | tee cal1.ics > cal2.ics &&
| > rpm -q python3-vobject &&
| > ics_diff cal1.ics cal2.ics'; done
|   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
|                                  Dload  Upload   Total   Spent    Left  Speed
|   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
| python3-vobject-0.9.8-1.fc40.noarch
| Traceback (most recent call last):
|   File "/usr/bin/ics_diff", line 33, in <module>
|     sys.exit(load_entry_point('vobject==0.9.8', 'console_scripts', 'ics_diff')())
|              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|   File "/usr/lib/python3.12/site-packages/vobject/ics_diff.py", line 200, in main
|     cal1 = readOne(f)
|            ^^^^^^^
| NameError: name 'readOne' is not defined
| [ 1/14] Verify package files            100% | 200.0   B/s |  12.0   B |  00m00s
| [ 2/14] Prepare transaction             100% | 137.0   B/s |  12.0   B |  00m00s
| [ 3/14] Installing expat-0:2.6.4-1.fc41 100% |   6.3 MiB/s | 295.0 KiB |  00m00s
| [ 4/14] Installing python-pip-wheel-0:2 100% | 206.9 MiB/s |   1.2 MiB |  00m00s
| [ 5/14] Installing mpdecimal-0:2.5.1-16 100% |  28.7 MiB/s | 206.0 KiB |  00m00s
| [ 6/14] Installing libb2-0:0.98.1-12.fc 100% |   3.5 MiB/s |  43.3 KiB |  00m00s
| [ 7/14] Installing python3-libs-0:3.13. 100% |  79.1 MiB/s |  40.6 MiB |  00m01s
| [ 8/14] Installing python3-0:3.13.1-2.f 100% |   5.3 MiB/s |  32.4 KiB |  00m00s
| [ 9/14] Installing python3-six-0:1.16.0 100% |  23.6 MiB/s | 120.7 KiB |  00m00s
| [10/14] Installing python3-dateutil-1:2 100% |  58.1 MiB/s | 892.9 KiB |  00m00s
| [11/14] Installing python3-pytz-0:2024. 100% |  22.4 MiB/s | 229.0 KiB |  00m00s
| [12/14] Installing python3-setuptools-0 100% |  84.3 MiB/s |   7.3 MiB |  00m00s
| [13/14] Installing python3-vobject-0:0. 100% |  52.4 MiB/s | 429.2 KiB |  00m00s
| [14/14] Installing python-unversioned-c 100% | 476.0   B/s | 424.0   B |  00m01s
|   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
|                                  Dload  Upload   Total   Spent    Left  Speed
|   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
| python3-vobject-0.9.8-1.fc41.noarch
| Traceback (most recent call last):
|   File "/usr/bin/ics_diff", line 33, in <module>
|     sys.exit(load_entry_point('vobject==0.9.8', 'console_scripts', 'ics_diff')())
|              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
|   File "/usr/lib/python3.13/site-packages/vobject/ics_diff.py", line 200, in main
|     cal1 = readOne(f)
|            ^^^^^^^
| NameError: name 'readOne' is not defined
| $

I'm not sure whether this is an error upstream or caused by Fedora's packaging.

Reproducible: Always

Comment 1 Peter Bieringer 2024-12-27 17:20:37 UTC

Looks like an upstream bug.

python3-vobject-0.9.6.1-20.fc40.noarch -> ok
python3-vobject-0.9.8-1.fc40.noarch -> problem

found change in /usr/lib/python3.12/site-packages/vobject/ics_diff.py:

-from .base import Component, getBehavior, newFromBehavior, readOne
+import vobject

workaround:

--- /usr/lib/python3.12/site-packages/vobject/ics_diff.py.orig	2024-12-27 18:17:24.291792633 +0100
+++ /usr/lib/python3.12/site-packages/vobject/ics_diff.py	2024-12-27 18:17:38.124558660 +0100
@@ -197,8 +197,8 @@
         ignore_dtstamp = options.ignore
         ics_file1, ics_file2 = args
         with open(ics_file1) as f, open(ics_file2) as g:
-            cal1 = readOne(f)
-            cal2 = readOne(g)
+            cal1 = vobject.readOne(f)
+            cal2 = vobject.readOne(g)
         deleteExtraneous(cal1, ignore_dtstamp=ignore_dtstamp)
         deleteExtraneous(cal2, ignore_dtstamp=ignore_dtstamp)
         prettyDiff(cal1, cal2)

=> please file issue to upstream incl. adding a test for ics_diff (which looks like currently missing)

Comment 2 Tim Landscheidt 2025-01-10 13:45:35 UTC

Thanks for the analysis!  I've filed a bug report upstream at https://github.com/py-vobject/vobject/issues/95.

Comment 3 Aoife Moloney 2025-04-28 15:28:22 UTC

This message is a reminder that Fedora Linux 40 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 40 on 2025-05-13.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '40'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 40 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 4 Peter Bieringer 2025-04-29 04:14:49 UTC

Issue still exists

rpm -qf /usr/bin/ics_diff
python3-vobject-0.9.8-2.fc42.noarch

Comment 5 Aoife Moloney 2026-08-17 13:20:23 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 45 development cycle.
Changing version to 45.