Bug 2334845

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8453956
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334845-golang-github-bep-imagemeta/fedora-rawhide-x86_64/08453956-golang-github-bep-imagemeta/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> %if %{without bootstrap}
> %build
> for cmd in gen; do
>   %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
> done
> %endif

I think this is a testing app not required. If so, can you remove it? To remove it also remove the %files section and 

> install -m 0644 -vp metadecoder_iptc_fields.json %{buildroot}%{_datarootdir}/gocode/src/github.com/bep/imagemeta

Can you replace with:

%global gosupfiles      metadecoder_iptc_fields.json

You can use https://src.fedoraproject.org/rpms/golang-github-projectdiscovery-goflags/blob/rawhide/f/golang-github-projectdiscovery-goflags.spec#_17 as example

Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-imagemeta.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-imagemeta-0.8.3-1.fc41.src.rpm
Description: Go library for reading EXIF, IPTC and XMP image meta data from JPEG, TIFF, PNG, and WebP files.
Fedora Account System Username: mikep

- Defined gosupfiles
- Removed %build section
- Removed explicit install of metadecoder_iptc_fields.json
- Removed %files section
- Removed explicit include of metadecoder_iptc_fields.json following %gopkgfiles

Created attachment 2064326 [details]
The .spec file difference from Copr build 8453956 to 8456267

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8456267
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334845-golang-github-bep-imagemeta/fedora-rawhide-x86_64/08456267-golang-github-bep-imagemeta/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> E: summary-too-long Go library for reading EXIF, IPTC and XMP image meta data from JPEG, TIFF, PNG, and WebP files

"Go library for reading EXIF, IPTC and XMP image meta data" works fine.

Change that before importing please.

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks for all your contributions in 2024!

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bep-imagemeta

FEDORA-2024-5825d02f27 (golang-github-bep-imagemeta-0.8.3-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5825d02f27

FEDORA-2024-5825d02f27 (golang-github-bep-imagemeta-0.8.3-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.