Bug 2334880

Summary:	Review Request: sdl-hercules - SoftDevLabs version of the Hercules S/370, ESA/390, and z/Arch Emulator
Product:	[Fedora] Fedora	Reporter:	Davide Cavalca <davide>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	ngompa13: fedora-review+
Hardware:	Unspecified
OS:	Unspecified
URL:	https://sdl-hercules-390.github.io/html/
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-12-30 00:04:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Davide Cavalca 2024-12-29 23:17:32 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/sdl-hercules/sdl-hercules.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/sdl-hercules/sdl-hercules-4.7-1.fc42.src.rpm

Description:
Hercules is an open source software implementation of the mainframe System/370
and ESA/390 architectures, in addition to the latest 64-bit z/Architecture.
Hercules runs under Linux, Windows, Solaris, FreeBSD, and Mac OS X.

This version of Hercules 4.x Hyperion is a SoftDevLabs maintained version of
the Hercules emulator containing fixes for bugs that may still exist in the
original hercules-390 version of Hercules 4.0 Hyperion, as well as enhancements
and improvements to the overall functionality above and beyond what is provided
by the hercules-390 version of Hercules.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-12-29 23:17:35 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=127384290

Comment 2 Neal Gompa 2024-12-29 23:20:42 UTC

Taking this review.

Comment 3 Fedora Review Service 2024-12-29 23:28:33 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8454386
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334880-sdl-hercules/fedora-rawhide-x86_64/08454386-sdl-hercules/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Neal Gompa 2024-12-29 23:35:21 UTC

Review notes:

* Package licensing is acceptable for Fedora (albeit very weird)
* Package license identification is correct
* Package license data is installed correctly
* Package builds and installs
* Package follows Fedora packaging guidelines
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2024-12-29 23:39:11 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/sdl-hercules

Comment 6 Fedora Update System 2024-12-30 00:01:45 UTC

FEDORA-2024-13ff46ab39 (sdl-hercules-4.7-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-13ff46ab39

Comment 7 Fedora Update System 2024-12-30 00:04:50 UTC

FEDORA-2024-13ff46ab39 (sdl-hercules-4.7-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2025-01-04 06:14:59 UTC

FEDORA-2025-f9a280c863 (sdl-hercules-4.7-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f9a280c863

Comment 9 Fedora Update System 2025-01-05 01:56:45 UTC

FEDORA-2025-f9a280c863 (sdl-hercules-4.7-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.