Bug 2335139
| Summary: | Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | wojnilowicz <lukasz.wojnilowicz> | ||||
| Component: | Package Review | Assignee: | Carlos Rodriguez-Fernandez <carlosrodrifernandez> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | carlosrodrifernandez, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | carlosrodrifernandez:
fedora-review+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://github.com/nyyManni/dmenu-wayland | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-01-02 21:25:54 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2335143 | ||||||
| Attachments: |
|
||||||
|
Description
wojnilowicz
2025-01-01 11:48:22 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8461129 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2335139-dmenu-wayland/fedora-rawhide-x86_64/08461129-dmenu-wayland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hi Lukasz,
The package is pretty complete.
I have one feedback, wouldn't you want to use pkgconfig instead?
$ diff -u dmenu-wayland.spec.orig dmenu-wayland.spec
--- dmenu-wayland.spec.orig 2025-01-01 15:40:07.432750735 -0700
+++ dmenu-wayland.spec 2025-01-01 16:03:38.828499401 -0700
@@ -13,12 +13,12 @@
Source: %{url}/archive/%{commit}/%{name}-%{short_commit}.tar.gz
BuildRequires: gcc
-BuildRequires: glib2-devel
+BuildRequires: pkgconfig(glib-2.0)
BuildRequires: pango-devel
-BuildRequires: cairo-devel
-BuildRequires: libxkbcommon-devel
-BuildRequires: wayland-devel
-BuildRequires: wayland-protocols-devel
+BuildRequires: pkgconfig(cairo)
+BuildRequires: pkgconfig(xkbcommon)
+BuildRequires: pkgconfig(wayland-client)
+BuildRequires: pkgconfig(wayland-protocols)
BuildRequires: meson
%description
pango is the onle one that doesn't have one, but the rest do. This is the reasoning behind it: https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/
I found that pango also has pkgconfig. Upstream meson build also expects that gobject-2.0, and pangocairo are provided as well at build time, and there are pkg-configs for them both as well. That way if something ever gets refactored in the actual packages providing those dependencies, your package would not be affected. (In reply to Carlos Rodriguez-Fernandez from comment #2) > Hi Lukasz, > The package is pretty complete. > I have one feedback, wouldn't you want to use pkgconfig instead? Hi Carlos, sure. I learned something new. Thanks. I corrected the spec file in-place. Could your approve now? [fedora-review-service-build] Created attachment 2064545 [details]
The .spec file difference from Copr build 8461129 to 8464552
Copr build: https://copr.fedorainfracloud.org/coprs/build/8464552 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2335139-dmenu-wayland/fedora-rawhide-x86_64/08464552-dmenu-wayland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thank you Lukasz! Approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/dmenu-wayland Thanks to you too for the review :) FEDORA-2025-8e0c872356 (dmenu-wayland-0.1^20241231.a380201-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-8e0c872356 FEDORA-2025-8e0c872356 (dmenu-wayland-0.1^20241231.a380201-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |