Bug 2335149
| Summary: | Review Request: libvlcpp - C++ bindings for libvlc | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> |
| Component: | Package Review | Assignee: | Simone Caronni <negativo17> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | negativo17, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | negativo17:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://code.videolan.org/videolan/libvlcpp | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-01-10 01:33:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2218117 | ||
|
Description
Dominik 'Rathann' Mierzejewski
2025-01-01 13:33:36 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8461218 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2335149-libvlcpp/fedora-rawhide-x86_64/08461218-libvlcpp/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. All good, just one minor thing. %make_install already provides the INSTALL variable pointing to `install -p`: $ rpm --eval %make_install /usr/bin/make install DESTDIR= INSTALL="/usr/bin/install -p" Otherwise package approved! The Pagure repository was created at https://src.fedoraproject.org/rpms/libvlcpp FEDORA-2025-0c332c6d1d (libvlcpp-0.1.0^20240204git44c1f48-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-0c332c6d1d FEDORA-2025-ac19a34ad2 (libvlcpp-0.1.0^20240204git44c1f48-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-ac19a34ad2 (In reply to Simone Caronni from comment #2) > All good, just one minor thing. %make_install already provides the INSTALL > variable pointing to `install -p`: > > $ rpm --eval %make_install > /usr/bin/make install DESTDIR= INSTALL="/usr/bin/install -p" Fixed. > Otherwise package approved! Thanks for the review! FEDORA-2025-ac19a34ad2 (libvlcpp-0.1.0^20240204git44c1f48-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-0c332c6d1d (libvlcpp-0.1.0^20240204git44c1f48-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |