Bug 2335183

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8462156
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2335183-golang-github-coder-websocket/fedora-rawhide-x86_64/08462156-golang-github-coder-websocket/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Can you keep the *generate_buildrequires part, but remove the modules required extra deps? Like this:

> %prep
> %goprep -A
> # Remove benchmark and examples to avoid extra deps
> rm -rf internal/examples internal/thirdparty

> %if %{without bootstrap}
> %generate_buildrequires
> %go_generate_buildrequires
> %endif

That way, if in the future it requires any module it should be easier to bump.

Spec URL: https://www.flyn.org/SRPMS/golang-github-coder-websocket.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-coder-websocket-1.8.12-1.fc41.src.rpm
Description: Minimal and idiomatic WebSocket library for Go
Fedora Account System Username: mikep

Revised to follow comment #2.

Created attachment 2064462 [details]
The .spec file difference from Copr build 8462156 to 8462299

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8462299
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2335183-golang-github-coder-websocket/fedora-rawhide-x86_64/08462299-golang-github-coder-websocket/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Forgot to mention that the thirdparty %check part can be be removed. If you can do it before importing would be great. 

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-coder-websocket

FEDORA-2025-ccedfad29b (golang-github-coder-websocket-1.8.12-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-ccedfad29b

FEDORA-2025-ccedfad29b (golang-github-coder-websocket-1.8.12-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.