Bug 2335293

https://release-monitoring.org/project/376196/

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8464223
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2335293-rust-notify-types/fedora-rawhide-x86_64/08464223-rust-notify-types/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8464224
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2335293-rust-notify-types/fedora-rawhide-x86_64/08464224-rust-notify-types/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

It looks like one included file still has the old license header: src/event.rs

This references the old CC0-1.0 / Artistic-ish license of notify < 6, so it's probably a mistake, but it would be good to get confirmation.

Other than that, the package LGTM.

(In reply to Fabio Valentini from comment #4)
> It looks like one included file still has the old license header:
> src/event.rs
> 
> This references the old CC0-1.0 / Artistic-ish license of notify < 6, so
> it's probably a mistake, but it would be good to get confirmation.
> 
> Other than that, the package LGTM.

Hmm, according to https://github.com/notify-rs/notify/commit/08e74dae8e96fbd25704cdaa530ffc02f6d33039#diff-fec21ee7a34c09969f535791a7963a9f59b57d12291e50864e0bb465aeb0e787 this file was just moved over from the notify crate, so the header is probably correct. (The actual notify crate wasn’t relicensed for 7.0.0; it’s still CC0-1.0.)

I guess I’ll open an upstream PR to adjust the crate license from MIT OR Apache-2.0 to (MIT OR Apache-2.0) AND (CC0-1.0 OR Artistic-2.0).

New Spec URL: https://music.fedorapeople.org/20250102/rust-notify-types.spec
New SRPM URL: https://music.fedorapeople.org/20250102/rust-notify-types-1.0.1-1.fc41.src.rpm

Created attachment 2064543 [details]
Updated configuration file for rust2rpm

The spec file is no longer the unmodified output of rust2rpm; some comments are added manually, and so is the LICENSE-CC0 file in the %files list.

Created attachment 2064544 [details]
The .spec file difference from Copr build 8464224 to 8464549

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8464549
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2335293-rust-notify-types/fedora-rawhide-x86_64/08464549-rust-notify-types/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thank you, this looks good to me. If the upstream project removes the differing license header from src/events.rs in the next release, as they suggest in the upstream ticket, the additional CC0-1.0 license can be dropped again. I agree that this use of CC0-1.0 for code in a new package falls under the rule that CC0-1.0 licensed code that was in Fedora before it was dropped as a "good" license, since the file in question has just been moved from the "notify" into the "notify-types" project as of version 7.0.0 of the "notify" crate.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
🫤 license matches upstream specification and is acceptable for Fedora (with justified clarifications)
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-notify-types

FEDORA-2025-3a3f9ff8bd (rust-notify-types-1.0.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-3a3f9ff8bd

FEDORA-2025-3a3f9ff8bd (rust-notify-types-1.0.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.