This service will be undergoing maintenance at 00:00 UTC, 2017-10-23 It is expected to last about 30 minutes

Bug 233596

Summary: Review Request: python-Coherence - Python framework to participate in digital living networks
Product: [Fedora] Fedora Reporter: Matthias Saou <matthias>
Component: Package ReviewAssignee: Xavier Lamien <lxtnow>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideFlags: lxtnow: fedora‑review+
wtogami: fedora‑cvs+
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-05-10 07:40:25 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 233598    

Description Matthias Saou 2007-03-23 08:31:16 EDT
Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/coherence/coherence.spec
SRPM URL: http://ftp.es6.freshrpms.net/tmp/extras/coherence/coherence-0.1.0-1.src.rpm
Description:
Coherence is a framework written in Python enabling applications to participate
in digital living networks, such as the UPnP universe.
Comment 1 Matthias Saou 2007-04-20 06:57:55 EDT
Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/coherence/coherence.spec
SRPM URL:
http://ftp.es6.freshrpms.net/tmp/extras/coherence/coherence-0.2.1-1.src.rpm

* Fri Apr 20 2007 Matthias Saou <http://freshrpms.net/> 0.2.1-1
- Update to 0.2.1.
Comment 2 Xavier Lamien 2007-05-04 12:29:38 EDT
Starting review
Comment 3 Matthias Saou 2007-05-07 07:21:34 EDT
Any results so far?
Comment 4 Xavier Lamien 2007-05-07 10:13:55 EDT
Yep,

OK - Mock Build on FC-Devel (noarch package
OK - Package meets naming and packaging guidelines
 ? - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License is MIT
OK - License text is present in the package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
0cc1e8dbcb0d30a7cdce0bf64cb7b4ff  Coherence-0.1.0.tar.gz
OK - Package has correct buildroot.
OK - BuildRequires isn't redundant.
OK - %build and %install stages is correct and work.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package is code or permissible content.
OK - No Scriplets is required for this package.
OK - %doc files don't affect runtime.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Changelog section is correct.
OK - rpmlint is silent on both SRPM and RPM files.

------

Just one comment:
Base package name is Coherence ( with an uppercase letter ) and your pre-built
package name start with an lowercase letter.
It doesn't match the packaging naming guideline.
Comment 5 Matthias Saou 2007-05-07 10:41:04 EDT
Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/Coherence/Coherence.spec
SRPM URL:
http://ftp.es6.freshrpms.net/tmp/extras/Coherence/Coherence-0.2.1-2.src.rpm

* Mon May  7 2007 Matthias Saou <http://freshrpms.net/> 0.2.1-2
- Rename coherence -> Coherence to match upstream and our naming guidelines.
- Obsolete coherence < 0.2.1-2 but don't provide it since elisa's requirement
  has been updated to match the name change and nothing else requires it.
Comment 6 Xavier Lamien 2007-05-07 12:47:37 EDT
+
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.

----
APROVED
----
Comment 7 Ville Skyttä 2007-05-07 15:02:02 EDT
As this is primarily (AFAIU) a framework/library package, shouldn't it be called
python-Coherence?
Comment 8 Matthias Saou 2007-05-08 04:28:00 EDT
> As this is primarily (AFAIU) a framework/library package, shouldn't it be called
> python-Coherence?

Very good point. I actually think it would make most sense indeed, so I'm fine
with renaming it once more ;-)
Comment 9 Matthias Saou 2007-05-08 10:32:11 EDT
Spec URL:
http://ftp.es6.freshrpms.net/tmp/extras/python-Coherence/python-Coherence.spec
SRPM URL:
http://ftp.es6.freshrpms.net/tmp/extras/python-Coherence/python-Coherence-0.2.1-3.src.rpm

* Tue May  8 2007 Matthias Saou <http://freshrpms.net/> 0.2.1-3
- Rename Coherence -> python-Coherence to match our python naming guidelines.
Comment 10 Xavier Lamien 2007-05-08 10:55:35 EDT
Oh, i just forgot about python plugin/extension naming.
indeed...

Taking python naming guidelines into account, full review above doesn't change
except the apropriate package name which be set now.

Matthias, don't forget to change Elisa (bug #233598) Require name for Coherence,
it's not actually done. ;-)
Comment 11 Matthias Saou 2007-05-08 11:15:10 EDT
Changing the summary back (again)... I guess it was a mistake... (?)
As for Elisa's Coherence requirement, I'll update it now.

I will also be requesting CVS module creation. Thanks Xavier for the review, and
thanks Ville too for the last second insight!
Comment 12 Matthias Saou 2007-05-09 07:16:41 EDT
New Package CVS Request
=======================
Package Name: python-Coherence
Short Description: Python framework to participate in digital living networks
Owners: matthias@rpmforge.net
Branches: devel FC-6 FC-5 EL-4 EL-5
InitialCC: 
Comment 13 Matthias Saou 2007-08-22 05:33:35 EDT
Package Change Request
======================
Package Name: python-Coherence
New Branches: F-7

For some reason, when devel was branched off for F-7, the F-7 branch of
python-Coherence wasn't created (no F-7 directory) :
[dude@python3 python-Coherence]$ cvs update -dP
cvs update: Updating .
cvs update: Updating EL-4
cvs update: Updating EL-5
cvs update: Updating FC-5
cvs update: Updating FC-6
cvs update: Updating devel