Bug 2336121

Created attachment 2065099 [details]
Proposed metainfo file

Could you pls look into this. If it seems OK, I'll put it into upcoming release.

Wow, thanks for working on this so quickly, Dmitry!

The metainfo file looks very good. I have just fixed the app id that should be in a rDNS format (both in the id tag and in the actual file name), added the developer id (that is mandatory for the developer tag to be parsed correctly) and added empty OARS metadata (that are required by some AppStream parsers/validators nowadays). The rest looks good.

Here is a diff of my changes:

diff --git a/seamonkey.metainfo.xml b/org.seamonkey_project.SeaMonkey.metainfo.xml
index 50d0a60..8a6ef22 100644
--- a/seamonkey.metainfo.xml
+++ b/org.seamonkey_project.SeaMonkey.metainfo.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <component type="desktop">
-  <id>seamonkey</id>
+  <id>org.seamonkey_project.SeaMonkey</id>
   <metadata_license>CC0-1.0</metadata_license>
   <project_license>MPL-2.0</project_license>
   <launchable type="desktop-id">seamonkey.desktop</launchable>
@@ -44,7 +44,7 @@
   <url type="vcs-browser">https://gitlab.com/users/seamonkey-project/projects</url>
   <url type="contribute">https://www.seamonkey-project.org/dev/get-involved</url>
 -->
-  <developer>
+  <developer id="org.seamonkey_project">
     <name>SeaMonkey Project</name>
   </developer>
   <update_contact>seamonkey-maintainers</update_contact>
@@ -81,4 +81,5 @@
       <image type="source">https://www.seamonkey-project.org/doc/img-screen/linux/mailcompose.png</image>
     </screenshot>
   </screenshots>
-</component>
\ No newline at end of file
+  <content_rating type="oars-1.1"/>
+</component>

Created attachment 2065100 [details]
Proposed metainfo file with small fixes

Validated by appstreamcli and verified to be correct.

Can I name the file just as "seamonkey.metainfo.xml" (since the desktop file now named as "seamonkey.desktop")?

Accroding to https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic , 
> it is strongly encouraged to only use lowercase letters for the ID.
so maybe "org.seamonkey_project.seamonkey" for the id instead?

According to Firefox spec, the "org." prefix appears since Fedora >= 40. What about epel8 and epel9 branches? Is it safe to place as "org." there as well?

There are two .desktop files -- "seamonkey.desktop" (to be initially launched as browser) and "seamonkey-mail.desktop" (to be launched as email client). Actually, the application is the same, just the "-mail" cmdline option is used in the second case. So should the metainfo file have a mention of "seamonkey-mail.desktop" too, or just ignore it for simplifity?

(In reply to Dmitry Butskoy from comment #4)
> Can I name the file just as "seamonkey.metainfo.xml" (since the desktop file
> now named as "seamonkey.desktop")?
> 
> Accroding to
> https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-
> id-generic , 
> > it is strongly encouraged to only use lowercase letters for the ID.
> so maybe "org.seamonkey_project.seamonkey" for the id instead?

No, the file name should be the same as the app id and the app id should be in rDNS format.

Sure, you can use a lower case "org.seamonkey_project.seamonkey" variant, it does not matter.
(The irony is that even some of the original AppStream standard creators use upper case app names in their projects. :-) You just have to make sure that the developer/domain part of the rDNS app id (org.seamonkey_project.) is in lower case.)

(In reply to Dmitry Butskoy from comment #5)
> According to Firefox spec, the "org." prefix appears since Fedora >= 40.
> What about epel8 and epel9 branches? Is it safe to place as "org." there as
> well?
> 
> There are two .desktop files -- "seamonkey.desktop" (to be initially
> launched as browser) and "seamonkey-mail.desktop" (to be launched as email
> client). Actually, the application is the same, just the "-mail" cmdline
> option is used in the second case. So should the metainfo file have a
> mention of "seamonkey-mail.desktop" too, or just ignore it for simplifity?

Sorry, I don't know about epel branches and to be honest, the Firefox spec file is quite a mess (and hard to understand) in some parts.

Do not worry about the seamonkey-mail.desktop. You just have to specify the main desktop file in AppStream metadata. It is mainly used for three things:
1. Point to the correct desktop icon file name that can be used in metadata.
2. Provide launchable for when clicking the "Launch" button on SeaMonkey details page in GNOME Software / KDE Discover.
3. Open correct details page when clicking an "App Details" option in GNOME Shell Overview.

FEDORA-2025-135cf1b7f3 (seamonkey-2.53.20-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-135cf1b7f3

FEDORA-2025-4945eb6eeb (seamonkey-2.53.20-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-4945eb6eeb

FEDORA-EPEL-2025-dd0247bebf (seamonkey-2.53.20-2.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-dd0247bebf

FEDORA-EPEL-2025-ef6b6c8d41 (seamonkey-2.53.20-2.el8) has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-ef6b6c8d41

FEDORA-EPEL-2025-ef6b6c8d41 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-ef6b6c8d41

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-4945eb6eeb has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-4945eb6eeb`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-4945eb6eeb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-EPEL-2025-dd0247bebf has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-dd0247bebf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-135cf1b7f3 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-135cf1b7f3`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-135cf1b7f3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-EPEL-2025-ef6b6c8d41 (seamonkey-2.53.20-2.el8) has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-135cf1b7f3 (seamonkey-2.53.20-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-4945eb6eeb (seamonkey-2.53.20-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-EPEL-2025-dd0247bebf (seamonkey-2.53.20-2.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.