Bug 2336266
| Summary: | abseil-cpp fails to build with GCC 15 (-Wtemplate-body or #include <cstdint> ?) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dave Malcolm <dmalcolm> |
| Component: | abseil-cpp | Assignee: | Ben Beasley <code> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | code, richmattes |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | abseil-cpp-20240722.0-3.fc42 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-01-15 06:22:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2333037 | ||
|
Description
Dave Malcolm
2025-01-07 22:54:35 UTC
Thank you for the heads-up! I think I remember that similar fixes have been required in the past. This is going to keep happening from time to time as long as upstream doesn’t practice include-what-you-use in general. It looks like this has already been fixed upstream in https://github.com/abseil/abseil-cpp/pull/1739. I would have preferred a broader fix, at least one that included <cstdint> / <stdint.h> directly in each file that used uintptr_t / intptr_t, but assuming that the extremely narrow fix works for now, I won’t bother opening another upstream PR. I’ll backport the fix via https://github.com/abseil/abseil-cpp/pull/1739.patch and test it against your COPR. Before I merge and build that, I need to finish analyzing, reporting, and skipping a test regression that’s showed up in Koschei recently on ppc64le. Still, expect to see a build closing this bug in the coming day or two. (In reply to Ben Beasley from comment #1) > I’ll backport the fix via > https://github.com/abseil/abseil-cpp/pull/1739.patch and test it against > your COPR. Before I merge and build that, I need to finish analyzing, > reporting, and skipping a test regression that’s showed up in Koschei > recently on ppc64le. Still, expect to see a build closing this bug in the > coming day or two. I backported the fix, but I had trouble figuring out where I could actually test it against GCC 15. Would you please test https://src.fedoraproject.org/rpms/abseil-cpp/pull-request/23 and confirm that it resolves all GCC 15 regressions? Thanks! I’m testing this with a scratch build in the f42-build-side-10330 side tag, announced on the devel list as available for GCC 15 testing: https://koji.fedoraproject.org/koji/taskinfo?taskID=127880775 That seems to be succeeding, so I’m going to merge the PR ahead of the mass rebuild. FEDORA-2025-eb1b292e61 (abseil-cpp-20240722.0-3.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-eb1b292e61 FEDORA-2025-eb1b292e61 (abseil-cpp-20240722.0-3.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |