Bug 2336274

I'm experimentally rebuilding rawhide with the not-yet-released GCC 15 to see if anything breaks, and to help write the porting guide.  See https://fedoraproject.org/wiki/User:Dmalcolm/gcc-15

My test build with GCC 15 failed:
https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-15-smoketest-3.failed/build/8476072/

whereas my test build with GCC 14 succeeded:
https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-15-smoketest-3.failed.checker/build/8477651/

Looking at the failure logs e.g.
https://download.copr.fedorainfracloud.org/results/dmalcolm/gcc-15-smoketest-3.failed/fedora-rawhide-x86_64/08476072-alpine/builder-live.log.gz

I see:

In file included from collate.c:15:
collate.c: In function 'set_collation':
../../include/system.h:94:19: error: conflicting types for 'strcoll'; have 'int(void)'
   94 | # define collator strcoll
      |                   ^~~~~~~
collate.c:29:16: note: in expansion of macro 'collator'
   29 |     extern int collator();  /* set to strcoll if available in system.h */
      |                ^~~~~~~~
In file included from ../../include/system.h:45:
/usr/include/string.h:163:12: note: previous declaration of 'strcoll' with type 'int(const char *, const char *)'
  163 | extern int strcoll (const char *__s1, const char *__s2)
      |            ^~~~~~~
collate.c:31:15: error: assignment to 'int (*)(void)' from incompatible pointer type 'int (*)(char *, char *)' [-Wincompatible-pointer-types]
   31 |     pcollator = strucmp;
      |               ^
collate.c: In function 'sstrcasecmp':
collate.c:79:13: error: too many arguments to function 'pcollator'
   79 |     return((*pcollator)(*(char **)s1, *(char **)s2));
      |            ~^~~~~~~~~~~


This is probably due to GCC 15 now defaulting to -std=gnu23, whereas GCC 14 defaulted to -std=gnu17, and C23 is stricter about function prototypes than C17.  It's probably fixable by fixing the function prototypes (or by manually adding -std=gnu17 to the C build flags)


Reproducible: Always