Bug 2337051

Summary:	Review Request: retroarch-assets - Assets needed for RetroArch - e.g. menu drivers, etc
Product:	[Fedora] Fedora	Reporter:	Artem <ego.cordatus>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	NEW ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, quantum.analyst
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://www.libretro.com/
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2290413

Description Artem 2025-01-11 00:21:38 UTC

Spec URL: https://atim.fedorapeople.org/retroarch-assets.spec
SRPM URL: https://atim.fedorapeople.org/retroarch-assets-1.19.0-1.fc41.src.rpm

Description:
The retroarch-assets repository is the home of the user interface elements
used to generate the various User Experience (UX) environments. The UX
environments are referred to as "menu drivers" and you can switch between
environments on most platforms at any time.

Fedora Account System Username: atim

Comment 1 Artem 2025-01-11 00:21:41 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=127751517

Comment 2 Artem 2025-01-11 00:26:49 UTC

Rationale:
This more like re-review. Rationale: RetroArch now using release tags for their sub-projects like assets, databases, etc (see: https://github.com/libretro/retroarch-assets/issues/414). Splitting RPM sub-packages to separate packages will make it easier updating/building RetroArch and all it's stuff. It also could simplify Spec file for RPM Fusion build and speedup building process, save disc space (assets SRPM itself is about ~470MB).

retroarch-assets would be better to keep as weak dep since some users still prefer to download it manually from app itself.

Comment 3 Fedora Review Service 2025-01-11 00:48:39 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8500573
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2337051-retroarch-assets/fedora-rawhide-x86_64/08500573-retroarch-assets/fedora-review/review.txt

Found issues:

- License file DejaVuSans.LICENSE.txt is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Elliott Sales de Andrade 2025-01-15 06:23:11 UTC

Your Source0 URL appears broken. I don't know if the short_url macro is really helping there either since it's only used in the one place.

You have marked the `sounds` directory as containing CC-BY-NC-3.0; this license is not permitted in Fedora, and I don't see you removing these files. It's also not listed in the License?

You have marked bundled fonts (and it would be helpful to comment where they are), but don't have their license in License.