Bug 2338878

Summary:	Incorrect indludedir path in pkgconfig config file
Product:	[Fedora] Fedora	Reporter:	MTRNord <mtrnord>
Component:	ldns	Assignee:	Petr Menšík <pemensik>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	41	CC:	dns-sig, italo.garcia+fedora, paul.wouters, pemensik, rj.layco, rlescak, rominf
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	ldns-1.8.4-7.fc44	Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-09-17 11:12:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description MTRNord 2025-01-19 17:45:33 UTC

The fedora 41 package provides a ldns.pc file. This file currently includes the line `includedir=/usr/include/ldns/ldns`. However, the package instead writes the include files to `includedir=/usr/include/ldns` which results in a `/usr/include/ldns/ldns` not found error when used with tools like cmake as the path was incorrect.

Reproducible: Always

Steps to Reproduce:
1. Compare the ldns.pc file with the real files on disk
Actual Results:  
They do not match

Expected Results:  
The includedir option matches the on-disk structure

Comment 1 Petr Menšík 2025-09-16 08:50:03 UTC

Ah, correct. Not sure how it went wrong, but you are right it is.

On top of that, there is also ldns-config tool provided by ldns-devel package. That has just /usr/include in its include path.
This were done by wrong sed in spec file, which overrides updated include after multilib patch. Adding /ldns twice.

But, projects like dnsperf include ldns by #include <ldns/ldns.h> statement and that means no include path specification is needed. Default should be okay, that would by why nobody complained about this before. I would recommend using include <ldns/*.h> in any your projects too.

But yes, let's fix this too.

Comment 2 Fedora Update System 2025-09-17 10:21:01 UTC

FEDORA-2025-49153d2433 (ldns-1.8.4-7.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-49153d2433

Comment 3 Fedora Update System 2025-09-17 11:12:46 UTC

FEDORA-2025-49153d2433 (ldns-1.8.4-7.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.