Bug 2338880

Summary: Review Request: rust-tree-sitter-generate - Library for generating C source code from a tree-sitter grammar
Product: [Fedora] Fedora Reporter: Aleksei Bavshin <alebastr89>
Component: Package ReviewAssignee: Andreas Schneider <asn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: asn, package-review
Target Milestone: ---Flags: asn: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/tree-sitter-generate
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-02-01 05:46:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2279201    

Description Aleksei Bavshin 2025-01-19 18:01:08 UTC
Spec URL: https://alebastr.fedorapeople.org/review/rust-tree-sitter-generate/rust-tree-sitter-generate.spec
SRPM URL: https://alebastr.fedorapeople.org/review/rust-tree-sitter-generate/rust-tree-sitter-generate-0.24.7-1.fc41.src.rpm

Description:
Library for generating C source code from a tree-sitter grammar.

Fedora Account System Username: alebastr

Comment 1 Fedora Review Service 2025-01-19 18:03:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8547027
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338880-rust-tree-sitter-generate/fedora-rawhide-x86_64/08547027-rust-tree-sitter-generate/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Andreas Schneider 2025-01-28 14:46:03 UTC
I can't run fedora-review on this as rust-tree-sitter is not updated yet:

Problem: nothing provides requested (crate(tree-sitter/default) >= 0.24.5 with crate(tree-sitter/default) < 0.25.0~)

Comment 3 Aleksei Bavshin 2025-01-29 18:32:48 UTC
(In reply to Andreas Schneider from comment #2)
> I can't run fedora-review on this as rust-tree-sitter is not updated yet:

rust-tree-sitter will be in the next rawhide compose. If you don't want to wait, you can use this copr build: https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/build/8585142/

Comment 4 Andreas Schneider 2025-01-30 18:41:37 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 38 files have unknown license. Detailed
     output of licensecheck in
     /home/asn/workspace/pkg/fedora/REVIEW/2338880-rust-tree-sitter-
     generate/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     tree-sitter-generate-devel , rust-tree-sitter-generate+default-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rust-tree-sitter-generate-devel-0.24.7-1.fc42.noarch.rpm
          rust-tree-sitter-generate+default-devel-0.24.7-1.fc42.noarch.rpm
          rust-tree-sitter-generate-0.24.7-1.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp_fx64edu')]
checks: 32, packages: 3

rust-tree-sitter-generate+default-devel.noarch: W: no-documentation
 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 12 filtered, 0 badness; has taken 0.3 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

rust-tree-sitter-generate+default-devel.noarch: W: no-documentation
 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://github.com/tree-sitter/tree-sitter/raw/v0.24.7/LICENSE#/LICENSE.upstream :
  CHECKSUM(SHA256) this package     : 5f9cf9fb6acb1972b35ae29119ce563bb60ec097656bc4b69b9bac2d04c7a147
  CHECKSUM(SHA256) upstream package : 5f9cf9fb6acb1972b35ae29119ce563bb60ec097656bc4b69b9bac2d04c7a147
https://crates.io/api/v1/crates/tree-sitter-generate/0.24.7/download#/tree-sitter-generate-0.24.7.crate :
  CHECKSUM(SHA256) this package     : bb80a800abfc08004646ec070013c9dbd302f85bafc0a0cc980c8350200e56d1
  CHECKSUM(SHA256) upstream package : bb80a800abfc08004646ec070013c9dbd302f85bafc0a0cc980c8350200e56d1


Requires
--------
rust-tree-sitter-generate-devel (rpmlib, GLIBC filtered):
    (crate(anyhow/default) >= 1.0.89 with crate(anyhow/default) < 2.0.0~)
    (crate(heck/default) >= 0.5.0 with crate(heck/default) < 0.6.0~)
    (crate(indexmap/default) >= 2.5.0 with crate(indexmap/default) < 3.0.0~)
    (crate(indoc/default) >= 2.0.5 with crate(indoc/default) < 3.0.0~)
    (crate(lazy_static/default) >= 1.5.0 with crate(lazy_static/default) < 2.0.0~)
    (crate(log/default) >= 0.4.22 with crate(log/default) < 0.5.0~)
    (crate(log/std) >= 0.4.22 with crate(log/std) < 0.5.0~)
    (crate(regex-syntax/default) >= 0.8.4 with crate(regex-syntax/default) < 0.9.0~)
    (crate(regex/default) >= 1.10.6 with crate(regex/default) < 2.0.0~)
    (crate(rustc-hash/default) >= 2.0.0 with crate(rustc-hash/default) < 3.0.0~)
    (crate(semver/default) >= 1.0.23 with crate(semver/default) < 2.0.0~)
    (crate(semver/serde) >= 1.0.23 with crate(semver/serde) < 2.0.0~)
    (crate(serde/default) >= 1.0.210 with crate(serde/default) < 2.0.0~)
    (crate(serde/derive) >= 1.0.210 with crate(serde/derive) < 2.0.0~)
    (crate(serde_json/default) >= 1.0.128 with crate(serde_json/default) < 2.0.0~)
    (crate(serde_json/preserve_order) >= 1.0.128 with crate(serde_json/preserve_order) < 2.0.0~)
    (crate(smallbitvec/default) >= 2.5.3 with crate(smallbitvec/default) < 3.0.0~)
    (crate(tree-sitter/default) >= 0.24.5 with crate(tree-sitter/default) < 0.25.0~)
    (crate(url/default) >= 2.5.2 with crate(url/default) < 3.0.0~)
    (crate(url/serde) >= 2.5.2 with crate(url/serde) < 3.0.0~)
    cargo
    rust

rust-tree-sitter-generate+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(tree-sitter-generate)



Provides
--------
rust-tree-sitter-generate-devel:
    crate(tree-sitter-generate)
    rust-tree-sitter-generate-devel

rust-tree-sitter-generate+default-devel:
    crate(tree-sitter-generate/default)
    rust-tree-sitter-generate+default-devel



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2338880
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: Haskell, fonts, SugarActivity, R, Python, PHP, Ocaml, Java, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 5 Fedora Admin user for bugzilla script actions 2025-02-01 04:00:17 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tree-sitter-generate

Comment 6 Fedora Update System 2025-02-01 05:42:23 UTC
FEDORA-2025-d5bfff4016 (rust-fs4-0.9.1-1.fc42, rust-tree-sitter-cli-0.24.7-1.fc42, and 6 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d5bfff4016

Comment 7 Fedora Update System 2025-02-01 05:46:53 UTC
FEDORA-2025-d5bfff4016 (rust-fs4-0.9.1-1.fc42, rust-tree-sitter-cli-0.24.7-1.fc42, and 6 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.