Bug 2339108

Summary: Review Request: image-builder - an image building executable
Product: [Fedora] Fedora Reporter: Simon de Vlieger <cmdr>
Component: Package ReviewAssignee: Ondřej Budai <obudai>
Status: RELEASE_PENDING --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: obudai, package-review
Target Milestone: ---Flags: obudai: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .spec file difference from Copr build 8558130 to 8561079
none
The .spec file difference from Copr build 8561079 to 8563093 none

Description Simon de Vlieger 2025-01-21 11:54:10 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/@osbuild/image-builder/fedora-41-x86_64/08555502-image-builder/image-builder.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/@osbuild/image-builder/fedora-41-x86_64/08555502-image-builder/image-builder-6-1.20250121104637388188.main.1.g54d9ab4.fc41.src.rpm
Description: A local binary for building customized OS artifacts such as VM images and OSTree commits. Uses osbuild under the hood.
Fedora Account System Username: supakeen

This package provides bundled vendor dependencies as the effort on maintainers would be too large to package them all separately. It seems in general that Go packaging is moving in this direction.

All licenses from vendored code are included.

Comment 1 Fedora Review Service 2025-01-22 02:27:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8558130
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2339108-image-builder/fedora-rawhide-x86_64/08558130-image-builder/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ondřej Budai 2025-01-22 12:42:54 UTC
I think that some build requirements can be pruned, specifically these ones:

BuildRequires:  systemd
BuildRequires:  krb5-devel
BuildRequires:  python3-docutils
BuildRequires:  make
BuildRequires:  systemd-rpm-macros
BuildRequires:  git

If the git one cannot be removed, then you should at least make an attempt to reduce it to git-core, see https://fedoraproject.org/wiki/Changes/ChangeToGitCore

---

%bcond_with tests
%bcond_with relax_requires

don't seem to be used, just copy-paste artifacts from osbuild-composer.

---

ExcludeArch:   armv7hl

is no longer needed, it was retired in F37, see https://fedoraproject.org/wiki/Changes/RetireARMv7

---

Would be nice to switch to go-vendor-tools to align this with the rest of Fedora Go bundled RPMs. This is not mandated at this point, thus I will not block on it.

---

Source0 should be a full URL, otherwise please document how to generate the tarball.

---

A man page would be nice. This is not mandated, but highly recommended. I will not block on it. Cobra can generate the skeleton btw.

Also, bash/zsh/fish completions would be nice (I have no experience packaging this, though. :( )

---


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 4659 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.

Builds just fine.

[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: image-builder-6-1.20250121104637388188.main.1.g54d9ab4.fc42.x86_64.rpm
          image-builder-6-1.20250121104637388188.main.1.g54d9ab4.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp9132f0pl')]
checks: 32, packages: 2

image-builder.src: E: spelling-error ('osbuild', 'Summary(en_US) osbuild -> build')
image-builder.src: E: spelling-error ('osbuild', '%description -l en_US osbuild -> build')
image-builder.x86_64: E: spelling-error ('osbuild', 'Summary(en_US) osbuild -> build')
image-builder.x86_64: E: spelling-error ('osbuild', '%description -l en_US osbuild -> build')
image-builder.x86_64: W: no-manual-page-for-binary image-builder
image-builder.spec: W: invalid-url Source0: image-builder-cli-6.tar.gz
 2 packages and 0 specfiles checked; 4 errors, 2 warnings, 7 filtered, 4 badness; has taken 0.7 s 




Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "image-builder-debuginfo".
(none): E: there is no installed rpm "image-builder".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 



Requires
--------
image-builder (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libcrypt.so.2()(64bit)
    libcrypt.so.2(XCRYPT_2.0)(64bit)
    libgpgme.so.11()(64bit)
    libgpgme.so.11(GPGME_1.0)(64bit)
    libgpgme.so.11(GPGME_1.1)(64bit)
    libresolv.so.2()(64bit)
    osbuild
    osbuild-depsolve-dnf
    osbuild-luks2
    osbuild-lvm2
    osbuild-ostree
    rtld(GNU_HASH)



Provides
--------
image-builder:
    bundled(golang(dario.cat/mergo))
    bundled(golang(github.com/BurntSushi/toml))
    bundled(golang(github.com/Microsoft/go-winio))
    bundled(golang(github.com/Microsoft/hcsshim))
    bundled(golang(github.com/VividCortex/ewma))
    bundled(golang(github.com/acarl005/stripansi))
    bundled(golang(github.com/asaskevich/govalidator))
    bundled(golang(github.com/containerd/cgroups/v3))
    bundled(golang(github.com/containerd/errdefs))
    bundled(golang(github.com/containerd/stargz-snapshotter/estargz))
    bundled(golang(github.com/containers/common))
    bundled(golang(github.com/containers/image/v5))
    bundled(golang(github.com/containers/libtrust))
    bundled(golang(github.com/containers/ocicrypt))
    bundled(golang(github.com/containers/storage))
    bundled(golang(github.com/cyberphone/json-canonicalization))
    bundled(golang(github.com/cyphar/filepath-securejoin))
    bundled(golang(github.com/davecgh/go-spew))
    bundled(golang(github.com/distribution/reference))
    bundled(golang(github.com/docker/distribution))
    bundled(golang(github.com/docker/docker))
    bundled(golang(github.com/docker/docker-credential-helpers))
    bundled(golang(github.com/docker/go-connections))
    bundled(golang(github.com/docker/go-units))
    bundled(golang(github.com/felixge/httpsnoop))
    bundled(golang(github.com/go-jose/go-jose/v4))
    bundled(golang(github.com/go-logr/logr))
    bundled(golang(github.com/go-logr/stdr))
    bundled(golang(github.com/go-openapi/analysis))
    bundled(golang(github.com/go-openapi/errors))
    bundled(golang(github.com/go-openapi/jsonpointer))
    bundled(golang(github.com/go-openapi/jsonreference))
    bundled(golang(github.com/go-openapi/loads))
    bundled(golang(github.com/go-openapi/runtime))
    bundled(golang(github.com/go-openapi/spec))
    bundled(golang(github.com/go-openapi/strfmt))
    bundled(golang(github.com/go-openapi/swag))
    bundled(golang(github.com/go-openapi/validate))
    bundled(golang(github.com/gobwas/glob))
    bundled(golang(github.com/gogo/protobuf))
    bundled(golang(github.com/golang/groupcache))
    bundled(golang(github.com/golang/protobuf))
    bundled(golang(github.com/google/go-containerregistry))
    bundled(golang(github.com/google/go-intervals))
    bundled(golang(github.com/google/uuid))
    bundled(golang(github.com/gorilla/mux))
    bundled(golang(github.com/hashicorp/errwrap))
    bundled(golang(github.com/hashicorp/go-multierror))
    bundled(golang(github.com/hashicorp/go-version))
    bundled(golang(github.com/inconshreveable/mousetrap))
    bundled(golang(github.com/josharian/intern))
    bundled(golang(github.com/json-iterator/go))
    bundled(golang(github.com/klauspost/compress))
    bundled(golang(github.com/klauspost/pgzip))
    bundled(golang(github.com/letsencrypt/boulder))
    bundled(golang(github.com/mailru/easyjson))
    bundled(golang(github.com/mattn/go-runewidth))
    bundled(golang(github.com/mattn/go-sqlite3))
    bundled(golang(github.com/miekg/pkcs11))
    bundled(golang(github.com/mistifyio/go-zfs/v3))
    bundled(golang(github.com/mitchellh/mapstructure))
    bundled(golang(github.com/moby/docker-image-spec))
    bundled(golang(github.com/moby/sys/mountinfo))
    bundled(golang(github.com/moby/sys/user))
    bundled(golang(github.com/modern-go/concurrent))
    bundled(golang(github.com/modern-go/reflect2))
    bundled(golang(github.com/oklog/ulid))
    bundled(golang(github.com/opencontainers/go-digest))
    bundled(golang(github.com/opencontainers/image-spec))
    bundled(golang(github.com/opencontainers/runtime-spec))
    bundled(golang(github.com/opencontainers/selinux))
    bundled(golang(github.com/osbuild/images))
    bundled(golang(github.com/ostreedev/ostree-go))
    bundled(golang(github.com/pkg/errors))
    bundled(golang(github.com/pmezard/go-difflib))
    bundled(golang(github.com/proglottis/gpgme))
    bundled(golang(github.com/rivo/uniseg))
    bundled(golang(github.com/secure-systems-lab/go-securesystemslib))
    bundled(golang(github.com/sigstore/fulcio))
    bundled(golang(github.com/sigstore/rekor))
    bundled(golang(github.com/sigstore/sigstore))
    bundled(golang(github.com/sirupsen/logrus))
    bundled(golang(github.com/spf13/cobra))
    bundled(golang(github.com/spf13/pflag))
    bundled(golang(github.com/stefanberger/go-pkcs11uri))
    bundled(golang(github.com/stretchr/testify))
    bundled(golang(github.com/sylabs/sif/v2))
    bundled(golang(github.com/syndtr/gocapability))
    bundled(golang(github.com/tchap/go-patricia/v2))
    bundled(golang(github.com/titanous/rocacheck))
    bundled(golang(github.com/ulikunitz/xz))
    bundled(golang(github.com/vbatts/tar-split))
    bundled(golang(github.com/vbauerster/mpb/v8))
    bundled(golang(go.mongodb.org/mongo-driver))
    bundled(golang(go.mozilla.org/pkcs7))
    bundled(golang(go.opencensus.io))
    bundled(golang(go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp))
    bundled(golang(go.opentelemetry.io/otel))
    bundled(golang(go.opentelemetry.io/otel/metric))
    bundled(golang(go.opentelemetry.io/otel/trace))
    bundled(golang(golang.org/x/crypto))
    bundled(golang(golang.org/x/exp))
    bundled(golang(golang.org/x/net))
    bundled(golang(golang.org/x/sync))
    bundled(golang(golang.org/x/sys))
    bundled(golang(golang.org/x/term))
    bundled(golang(golang.org/x/text))
    bundled(golang(google.golang.org/genproto/googleapis/rpc))
    bundled(golang(google.golang.org/grpc))
    bundled(golang(google.golang.org/protobuf))
    bundled(golang(gopkg.in/ini.v1))
    bundled(golang(gopkg.in/yaml.v3))
    image-builder
    image-builder(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name image-builder --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: Python, R, Ocaml, Haskell, Perl, SugarActivity, C/C++, Java, fonts, PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 3 Simon de Vlieger 2025-01-22 22:47:39 UTC
@obudai thank you for the review!

Let me start off with the URLs to a new specfile and srpm:

Spec: https://supakeen.fedorapeople.org/for-review/image-builder.spec
SRPM: https://supakeen.fedorapeople.org/for-review/image-builder-8-1.20250122git5047b2c.fc41.src.rpm

I've addressed:

1. Removed the unused `bcond`s.
2. Removed the armv7hl excludearch.
3. Removed the unused buildrequires.

As for the other issues:

1. Source0 was filled in by COPR, it is normally %{gosource} so I don't directly control the URL that ends up there. What would you like me to write to make this clear in the specfile?
2. I will provide a manpage as soon as the upstream has slightly more proper documentation.
3. go-vendor-tools is on the tryout list, I've initially only used the license generation here but we do want to fit it into our workflow (later).

Let me know if you need anything else!

Comment 4 Fedora Review Service 2025-01-22 23:46:14 UTC
Created attachment 2073424 [details]
The .spec file difference from Copr build 8558130 to 8561079

Comment 5 Fedora Review Service 2025-01-22 23:46:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8561079
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2339108-image-builder/fedora-rawhide-x86_64/08561079-image-builder/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Simon de Vlieger 2025-01-23 09:15:29 UTC
Because the COPR build failed, here's them again (with the version set to the latest release):

Spec: https://supakeen.fedorapeople.org/for-review/image-builder.spec
SRPM: https://supakeen.fedorapeople.org/for-review/image-builder-7-1.fc41.src.rpm

Comment 7 Fedora Review Service 2025-01-23 13:26:15 UTC
Created attachment 2073532 [details]
The .spec file difference from Copr build 8561079 to 8563093

Comment 8 Fedora Review Service 2025-01-23 13:26:17 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8563093
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2339108-image-builder/fedora-rawhide-x86_64/08563093-image-builder/fedora-review/review.txt

Found issues:

- Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/image-builder/diff.txt
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Ondřej Budai 2025-01-23 14:51:59 UTC
Thanks! I was able to rebuild the spec file locally, and found no major issues. Just please fix the version in the changelog when importing the spec file into dist-git. Currently, it has only a dummy value.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 4909 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: image-builder-7-1.fc42.x86_64.rpm
          image-builder-7-1.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpy9ty7vmn')]
checks: 32, packages: 2

image-builder.src: E: spelling-error ('osbuild', 'Summary(en_US) osbuild -> build')
image-builder.src: E: spelling-error ('osbuild', '%description -l en_US osbuild -> build')
image-builder.x86_64: E: spelling-error ('osbuild', 'Summary(en_US) osbuild -> build')
image-builder.x86_64: E: spelling-error ('osbuild', '%description -l en_US osbuild -> build')
image-builder.x86_64: W: no-manual-page-for-binary image-builder
image-builder.x86_64: W: incoherent-version-in-changelog 0-1 ['7-1.fc42', '7-1']
 2 packages and 0 specfiles checked; 4 errors, 2 warnings, 7 filtered, 4 badness; has taken 0.4 s 




Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

image-builder.x86_64: W: unused-direct-shlib-dependency /usr/bin/image-builder /lib64/libresolv.so.2
image-builder.x86_64: E: spelling-error ('osbuild', 'Summary(en_US) osbuild -> build')
image-builder.x86_64: E: spelling-error ('osbuild', '%description -l en_US osbuild -> build')
image-builder.x86_64: W: no-manual-page-for-binary image-builder
image-builder.x86_64: W: incoherent-version-in-changelog 0-1 ['7-1.fc42', '7-1']
 2 packages and 0 specfiles checked; 2 errors, 3 warnings, 9 filtered, 2 badness; has taken 0.3 s 



Source checksums
----------------
https://github.com/osbuild/image-builder-cli/releases/download/v7/image-builder-cli-7.tar.gz :
  CHECKSUM(SHA256) this package     : ee657f38f8aebe31f9a0074d0885deea9537776e45de211372e13ba69fa54550
  CHECKSUM(SHA256) upstream package : ee657f38f8aebe31f9a0074d0885deea9537776e45de211372e13ba69fa54550


Requires
--------
image-builder (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libcrypt.so.2()(64bit)
    libcrypt.so.2(XCRYPT_2.0)(64bit)
    libgpgme.so.11()(64bit)
    libgpgme.so.11(GPGME_1.0)(64bit)
    libgpgme.so.11(GPGME_1.1)(64bit)
    libresolv.so.2()(64bit)
    osbuild
    osbuild-depsolve-dnf
    osbuild-luks2
    osbuild-lvm2
    osbuild-ostree
    rtld(GNU_HASH)



Provides
--------
image-builder:
    image-builder
    image-builder(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2339108
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: PHP, Ocaml, Python, C/C++, Haskell, SugarActivity, Java, fonts, Perl, R
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 11 Fedora Admin user for bugzilla script actions 2025-01-23 19:12:05 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/image-builder