Bug 2339960

Summary: cdrkit: FTBFS in Fedora rawhide/f42
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: cdrkitAssignee: Pavel Cahyna <pcahyna>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 42CC: hhorak, jkucera, pcahyna, tdawson, yselkowi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cdrkit-1.1.11-59.fc43 cdrkit-1.1.11-59.fc42 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-03-21 00:11:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2260875, 2300528    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2025-01-22 19:13:56 UTC
cdrkit failed to build from source in Fedora rawhide/f42

https://koji.fedoraproject.org/koji/taskinfo?taskID=127937817


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild
Please fix cdrkit at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
cdrkit will be orphaned. Before branching of Fedora 43,
cdrkit will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

Comment 1 Fedora Release Engineering 2025-01-22 19:13:59 UTC
Created attachment 2068463 [details]
build.log

file build.log too big, will only attach last 32768 bytes

Comment 2 Fedora Release Engineering 2025-01-22 19:14:01 UTC
Created attachment 2068464 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2025-01-22 19:14:02 UTC
Created attachment 2068465 [details]
state.log

Comment 4 Fedora Release Engineering 2025-01-22 20:43:22 UTC
*** Bug 2339579 has been marked as a duplicate of this bug. ***

Comment 5 Pavel Cahyna 2025-02-24 18:18:58 UTC
Seems to be due to the sbin - bin merge as there is at least one tool that gets installed to /usr/sbin.

Comment 6 Pavel Cahyna 2025-02-25 19:04:08 UTC
This patch seems to solve it (taken from lshw, https://src.fedoraproject.org/rpms/lshw/c/9afecdb1f2ea39b462601e29189b581adde055be?branch=rawhide)

diff -up cdrkit-1.1.11/netscsid/CMakeLists.txt.orig cdrkit-1.1.11/netscsid/CMakeLists.txt
--- cdrkit-1.1.11/netscsid/CMakeLists.txt.orig  2025-02-24 18:50:43.263679852 +0100
+++ cdrkit-1.1.11/netscsid/CMakeLists.txt       2025-02-25 19:42:09.519987622 +0100
@@ -9,5 +9,5 @@ ADD_EXECUTABLE (netscsid netscsid.c)
 #SET_SOURCE_FILES_PROPERTIES(netscsid.c )
 TARGET_LINK_LIBRARIES(netscsid ${EXTRA_LIBS} )
 #SET_TARGET_PROPERTIES(netscsid PROPERTIES  SKIP_BUILD_RPATH TRUE)
-INSTALL(TARGETS netscsid DESTINATION sbin)
+INSTALL(TARGETS netscsid DESTINATION ${CMAKE_INSTALL_SBINDIR})

Comment 7 Aoife Moloney 2025-02-26 13:26:45 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle.
Changing version to 42.

Comment 8 Yaakov Selkowitz 2025-03-18 18:23:07 UTC
That will require also adding `include(GNUInstallDirs)` (e.g. to the top-level CMakeLists.txt).

Comment 9 Fedora Update System 2025-03-20 19:16:55 UTC
FEDORA-2025-f40f7d1ba3 (cdrkit-1.1.11-59.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f40f7d1ba3

Comment 10 Fedora Update System 2025-03-20 22:49:05 UTC
FEDORA-2025-ce0acc72a9 (cdrkit-1.1.11-59.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-ce0acc72a9

Comment 11 Fedora Update System 2025-03-21 00:11:54 UTC
FEDORA-2025-ce0acc72a9 (cdrkit-1.1.11-59.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2025-03-21 03:16:00 UTC
FEDORA-2025-f40f7d1ba3 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-f40f7d1ba3`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-f40f7d1ba3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2025-03-25 00:16:18 UTC
FEDORA-2025-f40f7d1ba3 (cdrkit-1.1.11-59.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.