Bug 2340073

Summary: dhex: FTBFS in Fedora rawhide/f42
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: dhexAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 42CC: jskarvad, mruprich
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: dhex-0.69-16.fc43 dhex-0.69-16.fc42 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-03-12 15:11:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2260875, 2300528    
Attachments:
Description Flags
build.log
none
root.log
none
state.log
none
Patch none

Description Fedora Release Engineering 2025-01-22 19:27:16 UTC
dhex failed to build from source in Fedora rawhide/f42

https://koji.fedoraproject.org/koji/taskinfo?taskID=127944421


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild
Please fix dhex at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
dhex will be orphaned. Before branching of Fedora 43,
dhex will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

Comment 1 Fedora Release Engineering 2025-01-22 19:27:19 UTC
Created attachment 2068806 [details]
build.log

Comment 2 Fedora Release Engineering 2025-01-22 19:27:21 UTC
Created attachment 2068807 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2025-01-22 19:27:22 UTC
Created attachment 2068808 [details]
state.log

Comment 4 Fedora Release Engineering 2025-01-22 20:59:55 UTC
*** Bug 2339688 has been marked as a duplicate of this bug. ***

Comment 5 Michal Ruprich 2025-02-26 12:56:06 UTC
Adding a refreshed scratch build:

https://koji.fedoraproject.org/koji/taskinfo?taskID=129627056

The error is related to the new GCC:

main.c: In function ‘main’:
main.c:412:9: error: too many arguments to function ‘initcolors’; expected 0, have 1
  412 |         initcolors(output);
      |         ^~~~~~~~~~ ~~~~~~
In file included from menu.h:6,
                 from main.c:9:
output.h:10:6: note: declared here
   10 | void initcolors();
      |      ^~~~~~~~~~
make: *** [Makefile:38: main.o] Error 1

I did not find any Upstream repository, only a github mirror that does not seem very active. Adding a patch here. If there really is no upstream, I will create a PR with the fix directly in Fedora, just say the word.

Regards,
Michal Ruprich

Comment 6 Michal Ruprich 2025-02-26 12:57:19 UTC
Created attachment 2077894 [details]
Patch

Comment 7 Aoife Moloney 2025-02-26 13:28:17 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle.
Changing version to 42.

Comment 8 Jaroslav Škarvada 2025-03-12 14:54:45 UTC
Patch LGTM, thanks, I will send it upstream.

Comment 9 Fedora Update System 2025-03-12 15:07:10 UTC
FEDORA-2025-6b5960bb7e (dhex-0.69-16.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-6b5960bb7e

Comment 10 Fedora Update System 2025-03-12 15:11:54 UTC
FEDORA-2025-6b5960bb7e (dhex-0.69-16.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2025-03-12 15:25:13 UTC
FEDORA-2025-f219409965 (dhex-0.69-16.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f219409965

Comment 12 Jaroslav Škarvada 2025-03-12 15:55:20 UTC
Upstream accepted the patch.

Comment 13 Fedora Update System 2025-03-13 02:14:11 UTC
FEDORA-2025-f219409965 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-f219409965`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-f219409965

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2025-03-21 00:16:35 UTC
FEDORA-2025-f219409965 (dhex-0.69-16.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.