Bug 2341517

Summary: vpnc: FTBFS in Fedora rawhide/f42
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: vpncAssignee: Christian Krause <chkr>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 42CC: chkr, fschwarz, huzaifas, mjg, nixuser, quentin, rjones, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: vpnc-0.5.3^20241114.git11e15a1-1.fc42 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-04-26 01:55:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2267022, 2300528    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2025-01-22 22:17:12 UTC
vpnc failed to build from source in Fedora rawhide/f42

https://koji.fedoraproject.org/koji/taskinfo?taskID=128159868


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild
Please fix vpnc at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
vpnc will be orphaned. Before branching of Fedora 43,
vpnc will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

Comment 1 Fedora Release Engineering 2025-01-22 22:17:15 UTC
Created attachment 2073064 [details]
build.log

file build.log too big, will only attach last 32768 bytes

Comment 2 Fedora Release Engineering 2025-01-22 22:17:17 UTC
Created attachment 2073065 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2025-01-22 22:17:18 UTC
Created attachment 2073066 [details]
state.log

Comment 4 Aoife Moloney 2025-02-26 13:47:23 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle.
Changing version to 42.

Comment 5 Zbigniew Jędrzejewski-Szmek 2025-03-24 11:00:55 UTC
This package has files in /usr/sbin and the lack of rebuild is preventing the sbin merge from being finalized.

There's a PR to update to a newer snapshot. Could that be merged?

Comment 6 Richard W.M. Jones 2025-03-24 11:15:32 UTC
I rebased & pushed that:
https://src.fedoraproject.org/rpms/vpnc/pull-request/2

Comment 7 Richard W.M. Jones 2025-03-24 11:16:05 UTC
Rawhide build: https://koji.fedoraproject.org/koji/taskinfo?taskID=130688634

Comment 8 Felix Schwarz 2025-03-24 11:27:07 UTC
> There's a PR to update to a newer snapshot. Could that be merged?

I think vpnc is basically unmaintained. I removed myself from the committers list a couple of years ago because I did not want to ship a security-related package in Fedora which was dead upstream for so many years. I suggest to chkr that the package should be retired but obviously that did not happen. 

@chkr: Maybe it's time to orphan the package? Or add @lkundrak as co-maintainer if he want that?

Comment 9 Richard W.M. Jones 2025-03-24 11:27:23 UTC
error: Installed (but unpackaged) file(s) found:
   /usr/lib/debug/usr/sbin/vpnc-0.5.3^20241114.git11e15a1-1.fc43.x86_64.debug
   /usr/sbin/vpnc
   /usr/sbin/vpnc-disconnect
    File listed twice: /usr/bin/vpnc-helper
    Installed (but unpackaged) file(s) found:
   /usr/lib/debug/usr/sbin/vpnc-0.5.3^20241114.git11e15a1-1.fc43.x86_64.debug
   /usr/sbin/vpnc
   /usr/sbin/vpnc-disconnect

I don't really understand those errors as the %files section appears correct ...

Comment 10 Zbigniew Jędrzejewski-Szmek 2025-03-24 13:37:58 UTC
The problem is serious. The installation can be "fixed" by adding
- make install DESTDIR="$RPM_BUILD_ROOT" PREFIX=/usr
+ make install DESTDIR="$RPM_BUILD_ROOT" PREFIX=/usr SBINDIR=%{_sbindir}
The package then builds, but is actually broken. The problem is that
the consolehelper setup uses symlinks in /usr/bin to /usr/sbin, which
obviously cannot work if the two directories are the same.

One option is to drop the consolehelper wrapper.
The other option is to rename the real binaries (e.g. to /usr/libexec/vpnc
and /usr/libexec/vpnc-disconnect) and install the symlinks in /usr/bin.
But the consolehelper wrapper is optional, so if the real binaries are moved,
and the user doesn't have the -consoleuser subpackage installed, the
binaries will not be in $PATH. So it seems -consoleuser subpackage would
need to be merged with the main package.

I think the changes of this magnitude need to be made a by a maintainer…

Comment 11 Quentin Armitage 2025-04-21 14:08:29 UTC
This project appears to be being maintained at https://github.com/streambinder/vpnc.

Comment 12 Richard W.M. Jones 2025-04-23 14:40:44 UTC
We moved to using https://github.com/streambinder/vpnc and vpnc now compiles on F42 & Rawhide.

Comment 13 Fedora Update System 2025-04-23 14:41:09 UTC
FEDORA-2025-7128dc8637 (vpnc-0.5.3^20241114.git11e15a1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-7128dc8637

Comment 14 Fedora Update System 2025-04-24 03:48:00 UTC
FEDORA-2025-7128dc8637 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-7128dc8637`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-7128dc8637

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2025-04-26 01:55:59 UTC
FEDORA-2025-7128dc8637 (vpnc-0.5.3^20241114.git11e15a1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.