Bug 2342331

Summary: Review Request: rust-pty-process - Spawn commands attached to a pty
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Cristian Le <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: fedora: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/pty-process
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-02-08 14:31:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2342320    

Description Fabio Valentini 2025-01-27 19:31:38 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-pty-process.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-pty-process-0.4.0-1.fc41.src.rpm

Description:
Spawn commands attached to a pty.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2025-01-27 19:31:41 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=128536286

Comment 2 Fedora Review Service 2025-01-27 19:39:12 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8579144
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2342331-rust-pty-process/fedora-rawhide-x86_64/08579144-rust-pty-process/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Cristian Le 2025-02-06 15:54:38 UTC
All looks good

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
😑 test suite is run and all unit tests pass (the don't provide any)
❓ latest version of the crate is packaged (needing 0.4 for dependency)
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fabio Valentini 2025-02-06 19:11:10 UTC
Thank you for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2025-02-06 19:11:45 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pty-process

Comment 6 Fedora Update System 2025-02-08 14:29:05 UTC
FEDORA-2025-1a7dfe8856 (rust-pty-process-0.4.0-1.fc43, rust-sequoia-chameleon-gnupg-0.12.0-2.fc43, and 5 more) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-1a7dfe8856

Comment 7 Fedora Update System 2025-02-08 14:31:48 UTC
FEDORA-2025-1a7dfe8856 (rust-pty-process-0.4.0-1.fc43, rust-sequoia-chameleon-gnupg-0.12.0-2.fc43, and 5 more) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.