Bug 2342605

Summary:	Cannot close only one terminal window
Product:	[Fedora] Fedora	Reporter:	Zdenek Dohnal <zdohnal>
Component:	ptyxis	Assignee:	Nieves <nmontero>
Status:	CLOSED COMPLETED	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	41	CC:	chergert, gnome-sig, nmontero
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-03-19 01:20:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zdenek Dohnal 2025-01-28 16:13:31 UTC

I have opened 2+ windows of ptyxis and if I want to close one of them by clicking on cross in the top right corner, all ptyxis windows are closed.

$ rpm -q ptyxis
ptyxis-47.6-1.fc41.x86_64

Expected behavior:
Only one selected terminal windows is closed.

Reproducible: Always

Steps to Reproduce:
1.have 2+ ptyxis terminal windows opened
2. close one
3.
Actual Results:  
All ptyxis terminal windows are closed

Expected Results:  
only the selected one is closed

Comment 1 Christian Hergert 2025-01-29 20:38:46 UTC

That can only happen if Ptyxis crashed, which typically only happens if your GPU driver went kaput while trying to cleanup resources.

Can you check your crash logs? (`coredumpctl debug ptyxis` and then `bt` when in gdb to get the stack trace).

Additionally information about your GPU and what Mesa drivers (or otherwise) are installed are critical to further tracking down an issue. 

https://gitlab.gnome.org/chergert/ptyxis/-/issues/116
https://gitlab.gnome.org/chergert/ptyxis/-/issues/187
https://gitlab.gnome.org/chergert/ptyxis/-/issues/135
https://gitlab.gnome.org/chergert/ptyxis/-/issues/140

Possibly

https://gitlab.freedesktop.org/mesa/mesa/-/issues/10904

Comment 2 Zdenek Dohnal 2025-01-30 06:56:51 UTC

Nope, no coredumps in coredumpctl.

I found an interesting detail - all windows are closed if the following steps are done:

1. open ptyxis from the applications menu
2. make tabs in this ptyxis window
3. right click on a tab in ptyxis window -> select 'move to new window'
4. close the original ptyxis window

Voila! Even the forked window gets closed - no coredump and no error in journal - the only journal message is related to closure:

Jan 30 07:53:45 fedora systemd[2533]: dbus-:1.2-org.gnome.Ptyxis: Consumed 1.682s CPU time, 56.5M memory peak.

Comment 3 Christian Hergert 2025-01-30 19:09:22 UTC

It looks like for some reason it's not getting attached to the application instance (what inhibits exiting from the main loop). You can tell because the menu for the new window is not getting all of the shortcuts enabled in the primary menu.

I'll figure this out today and get a patch ready.

Comment 4 Christian Hergert 2025-01-30 19:14:41 UTC

The fix is here https://gitlab.gnome.org/chergert/ptyxis/-/commit/f05b513fdfb74e621944ff66ba43709eaaf88b3c and will be part of the eventual 47.9 release.

Comment 5 Zdenek Dohnal 2025-02-12 09:38:32 UTC

Can you backport the fix into F41 at least? The bug is quite annoying.

Comment 6 Christian Hergert 2025-02-13 21:03:50 UTC

47.10 has the fix, so it's waiting on Fedora packaging (I'm not a Fedora packager).

Comment 7 Zdenek Dohnal 2025-03-04 07:06:26 UTC

I've sent PR with the backported patch - https://src.fedoraproject.org/rpms/ptyxis/pull-request/5 - and it works . Can someone merge it and do the official build?

Comment 8 Nieves 2025-03-04 08:42:25 UTC

Hello Zdenek, I updated f41 to version 47.10, that according to Christian, has the fix for this problem. Please, check if the error persists or if it is solved with the update.