Bug 2342984

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=128655715

rust2rpm.toml: https://pagure.io/michel-slm/specs-for-review/blob/main/f/rust-tree-sitter-toml-ng/rust2rpm.toml

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8587804
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2342984-rust-tree-sitter-toml-ng/fedora-rawhide-x86_64/08587804-rust-tree-sitter-toml-ng/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- License file LICENSE is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

The devel package is missing the license file

I'll update this, thanks

Spec URL: https://salimma.fedorapeople.org/rust-tree-sitter-toml-ng.spec
SRPM URL: https://salimma.fedorapeople.org/rust-tree-sitter-toml-ng-0.7.0-1.fc43.src.rpm

includes license file properly now

❯ cat rust2rpm.toml
[package]
cargo-toml-patch-comments = [
  "include LICENSE",
]
license-files = [
  "LICENSE",
]

[[package.extra-sources]]
number = 1
file = "https://raw.githubusercontent.com/tree-sitter-grammars/tree-sitter-toml/refs/tags/v%{version}/LICENSE"
comments = [
  "include license file",
  "https://github.com/tree-sitter-grammars/tree-sitter-toml/pull/5",
]

[scripts.prep]
post = [
  """\
# copy in license file
cp -p %{SOURCE1} .\
""",
]

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tree-sitter-toml-ng

FEDORA-2025-a1e2f66d53 (rust-tree-sitter-toml-ng-0.7.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-a1e2f66d53

FEDORA-2025-a1e2f66d53 (rust-tree-sitter-toml-ng-0.7.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-685e0f9db0 (rust-tree-sitter-toml-ng-0.7.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-685e0f9db0

FEDORA-2025-387f344ba8 (rust-tree-sitter-toml-ng-0.7.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-387f344ba8

FEDORA-2025-cb2826c47a (rust-tree-sitter-toml-ng-0.7.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-cb2826c47a

FEDORA-2025-387f344ba8 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-387f344ba8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-387f344ba8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-685e0f9db0 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-685e0f9db0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-685e0f9db0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-cb2826c47a has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-cb2826c47a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-cb2826c47a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-cb2826c47a (rust-tree-sitter-toml-ng-0.7.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-685e0f9db0 (rust-tree-sitter-toml-ng-0.7.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-387f344ba8 (rust-tree-sitter-toml-ng-0.7.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.