Bug 234307
Summary: | Review Request: tuxpuck - Airhockey with a twist | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | gwync |
Target Milestone: | --- | Flags: | gauret:
fedora-review+
jwboyer: fedora-cvs- |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-04-05 19:06:43 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Hans de Goede
2007-03-28 12:31:38 UTC
Needs work: * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: Packaging/Guidelines#parallelmake) * Desktop file: the Categories tag should not contain X-Fedora any more (wiki: Packaging/Guidelines#desktop) * The pacakge should BuildRequire ImageMagick, and not Require it * The desktop-file spec requires at least a 48x48 icon, please generate one of this size too (In reply to comment #1) > Needs work: > * Missing SMP flags. If it doesn't build with it, please add a comment > (wiki: Packaging/Guidelines#parallelmake) I deliberately removed them comment added > * Desktop file: the Categories tag should not contain X-Fedora any more > (wiki: Packaging/Guidelines#desktop) Copy/paste error, removed. > * The pacakge should BuildRequire ImageMagick, and not Require it Oops, fixed > * The desktop-file spec requires at least a 48x48 icon, please generate one of > this size too I've re-read the freedesktop.org standard on this, and it says: "you should install a 48x48 icon in the hicolor theme". Notice the _should_, also the specified lookup algorithm will select the closest icon of a different size and scale that in software, I see no use in installing a prescaled icon, this won't be of any better quality then one scaled on the fly. New version with the above items fixed here: Spec URL: http://people.atrpms.net/~hdegoede/tuxpuck.spec SRPM URL: http://people.atrpms.net/~hdegoede/tuxpuck-0.8.2-2.fc7.src.rpm Review for release 2.fc6: * RPM name is OK * Source tuxpuck-0.8.2.tar.gz is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine (34 checks have been run) APPROVED New Package CVS Request ======================= Package Name: tuxpuck Short Description: Airhockey with a twist Owners: j.w.r.degoede Branches: FC-6 devel InitialCC: <empty> tuxpuck is already in Extras I cannot believe I've missed that, I'm somewhat sure I checked for this. Ah well. Sorry for the wastet time Aurelien. I'll atleast look over the version already in Extras and see if any improvements can be skooped from my version. FYI I've filed a bug with some enhancements to tuxpuck its bug 234566 Closed 234566, applied changes to existing tuxpuck. |