Bug 234330
| Summary: | Review Request: ruby-cairo - ruby bindings for cairo | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Allisson Azevedo <allisson> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | mtasaka:
fedora-review+
jwboyer: fedora-cvs+ |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-03-30 02:39:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 232160 | ||
|
Description
Allisson Azevedo
2007-03-28 14:58:37 UTC
For 1.4.1-1:
* License
- Well as Ruby uses "Ruby License/GPL", I would prefer
to use it.
* Group
- "Development/Languages" is for -devel package.
For libraries, this should be "System Environment/Libraries"
* Release number specific dependency
- Usually, provides or Requires for main package should be
release number specific.
* Ownership
- The following directories are not owned by any packages.
-------------------------------------------------
%{ruby_sitelib}/cairo/
%{ruby_sitelib}/cairo/context/
-------------------------------------------------
NOTE:
When you just write
-------------------------------------------------
%files
.....
foo/
-------------------------------------------------
(where foo is a directory), this means the directory foo itself
and all files/directories/etc under foo directory.
While if you write
-------------------------------------------------
%files
......
%dir foo/
-------------------------------------------------
This only contains the directory foo itself.
* Timestamps
- Again keep timestamps on non-generated files.
For this package, the following works.
-------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -c -p"
-------------------------------------------------
* %check
- Empty %check is not needed and please remove this.
* Requires
- %{ruby_sitearch}/rb_cairo.h contains the line:
------------------------------------------------
39 #include "ruby.h"
------------------------------------------------
This means that -devel package needs "Requires: ruby-devel".
NOTE:
- When you update spec file, please describe briefly how
you changed it in %changelog entry, not just write "Fix .spec".
Update package: Spec URL: http://fedora.allisson.eti.br/ruby-cairo/ruby-cairo.spec SRPM URL: http://fedora.allisson.eti.br/ruby-cairo/ruby-cairo-1.4.1-2.src.rpm Okay. ------------------------------------------- This package (ruby-cairo) is APPROVED by me. ------------------------------------------- New Package CVS Request ======================= Package Name: ruby-cairo Short Description: ruby bindings for cairo Owners: allisson Branches: FC-6 |