Bug 234368
| Summary: | Review Request: gnome-games-extra-data - themes for gnome-games | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> | ||||
| Component: | Package Review | Assignee: | Jochen Schmitt <jochen> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | rstrode | ||||
| Target Milestone: | --- | Flags: | jochen:
fedora-review+
wtogami: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-04-02 21:29:57 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Matthias Clasen
2007-03-28 18:43:00 UTC
> Requires: gnome-games >= 2.18.0-2
Should this say 2.18.0-2.fc7 ?
Actually, it should say 2.18.0-3.fc7 you have %define build_tali that i don't see referenced anywhere can we just drop the # # lawyers are fun # lawyers are fun little # comment? it seems like noise I've copied it from the gnome-games .spec, since it gives at least a hint why we remove gnometris, but sure, I can remove it or replace it by a more neutral comment. Spec and srpm updated Good:
+ Naming seems ok.
+ License is ok.
+ Tar ball matches upstream.
+ Local build works fine.
+ Rpmlint is ok on binary package.
Bad:
- URL tag is missing.
- Missing %{?_smp_mflags]
http://people.redhat.com/mclasen/gnome-games-extra-data/gnome-games-extra-data.spec http://people.redhat.com/mclasen/gnome-games-extra-data/gnome-games-extra-data-2.17.90-2.src.rpm Created attachment 151200 [details]
Local build log
Sorry, but something is wrong with your package.
When I try to build it, no binary packages will produced. The end of the build
log look like:
Heh. I added the smp flags to the spec file exactly as you asked for. Note the closing ] ... I've fixed that now. New spec file and srpm at the same place. Good: + Naming ok. + Tar ball metaches with upstream. + rpmlint quite on source package. + Local build works fine. + Rpmlint quite on binary package. + Local install and uninstall works fine. + License ok. + Package contains verbatin copy of the license text. New Package CVS Request
=======================
Package Name: gnome-games-extra-data
Short Description: The gnome-games-extra-data package includes additional data
and themes for the games in the gnome-games package.
Owners: mclasen
Branches: FC-7
InitialCC:
Built |