Bug 2343832
| Summary: | Review Request: phrog - Mobile-friendly greeter for greetd | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sam Day <me> | ||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | package-review | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/samcday/phrog | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-02-10 15:39:20 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2344240, 2344242 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Sam Day
2025-02-04 21:03:09 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8606598 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2343832-phrog/fedora-rawhide-x86_64/08606598-phrog/fedora-review/review.txt Found issues: - Systemd service file(s) in phrog Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets - Systemd user unit service file(s) in phrog Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I'd appreciate some advice on how to proceed with the OSK dependency. f-r-s has picked up on the fact that this package is depending on `/usr/share/applications/sm.puri.OSK0.desktop`. What I want here is for phrog to depend on *any* phosh OSK to be installed. Currently there's squeekboard and I've got an open review request for phosh-osk-stub (BZ#2343212). I've proposed changes to both phosh and squeekboard packages to use the alternatives system to manage the `sm.puri.OSK0.desktop` file: * https://src.fedoraproject.org/rpms/squeekboard/pull-request/5 * https://bugzilla.redhat.com/show_bug.cgi?id=2343212 Perhaps I should amend squeekboard and phosh-osk-stub to `Provides: phosh-osk` or some kind of virtual name? Spec URL: https://raw.githubusercontent.com/samcday/phrog/c3c3dfdbd6818dbc0486b483b043acb82af29477/phrog.spec Changes: * Enabled tests properly * Drop dependency on `/usr/share/applications/sm.puri.OSK0.desktop` for now in favour of `squeekboard` Not providing the SRPM to avoid triggering f-r-s, as this relies on two new crates that need packaging: https://bugzilla.redhat.com/show_bug.cgi?id=2344240 https://bugzilla.redhat.com/show_bug.cgi?id=2344242 Spec URL: https://raw.githubusercontent.com/samcday/fedora-msm8916/refs/heads/main/specs/phrog/phrog.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/samcday/msm8916/fedora-rawhide-aarch64/08813038-phrog/phrog-0.46.0-1742829627.fc43.src.rpm For now, tests are disabled until https://bugzilla.redhat.com/show_bug.cgi?id=2344240 is approved. Further, the squeekboard dependency is dropped until the phosh-osk stuff lands: https://src.fedoraproject.org/rpms/phosh/pull-request/7 + https://src.fedoraproject.org/rpms/squeekboard/pull-request/9 Created attachment 2081721 [details]
The .spec file difference from Copr build 8606598 to 8813424
Copr build: https://copr.fedorainfracloud.org/coprs/build/8813424 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2343832-phrog/fedora-rawhide-x86_64/08813424-phrog/fedora-review/review.txt Found issues: - Systemd service file(s) in phrog Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets - Systemd user unit service file(s) in phrog Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |