Bug 2344120

Summary: Review Request: rust-gst-plugin-rav1e - GStreamer rav1e AV1 encoder plugin
Product: [Fedora] Fedora Reporter: Yaakov Selkowitz <yselkowi>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review?
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/gst-plugin-rav1e
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yaakov Selkowitz 2025-02-06 04:54:26 UTC
Spec URL: https://yselkowitz.fedorapeople.org/rust-gst-plugin-rav1e.spec
SRPM URL: https://yselkowitz.fedorapeople.org/rust-gst-plugin-rav1e-0.13.0-1.fc42.src.rpm
Description: GStreamer rav1e AV1 encoder plugin
Fedora Account System Username: yselkowitz

Comment 1 Fedora Review Service 2025-02-06 05:06:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8612367
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344120-rust-gst-plugin-rav1e/fedora-rawhide-x86_64/08612367-rust-gst-plugin-rav1e/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-03-15 16:44:35 UTC
Similar questions as on the -ndi plugin:

- The Provides for the actual upstream name is missing compared to existing plugins from gst-plugins-rs, is that intentional?

- You're packaging gstreamer-check, would it make sense to wait until that's available, and then enable tests, or would you rather submit as-is and enable tests later?

Other than that, package LGTM.