Bug 2344133
| Summary: | Review Request: rust-gstreamer-rtp-sys - FFI bindings to libgstrtp-1.0 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaakov Selkowitz <yselkowi> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/gstreamer-rtp-sys | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-03-24 01:32:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2344134 | ||
|
Description
Yaakov Selkowitz
2025-02-06 05:54:53 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8612436 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344133-rust-gstreamer-rtp-sys/fedora-rawhide-x86_64/08612436-rust-gstreamer-rtp-sys/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good to me. Note that there was a 0.23.5 release in the meantime. Since there are no code changes, only string changes in comments and metadata, I won't block this review on that. GStreamer 1.26 has only just today landed in rawhide - you can add the v1_26 feature back to the package if you only plan to target Rawhide, otherwise I would recommend to import it *without* that so you can merge it back to f42 / f41 branches without having the branches diverge unnecessarily (that will come soon enough ...) === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (disabled with justification) 🫤 latest version of the crate is packaged (latest is 0.23.5, current is 0.23.4) ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gstreamer-rtp-sys FEDORA-2025-dad0c339e3 (rust-gstreamer-app-sys-0.23.5-1.fc42, rust-gstreamer-check-sys-0.23.5-1.fc42, and 2 more) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-dad0c339e3 FEDORA-2025-f504848417 (rust-gstreamer-app-sys-0.23.5-1.fc41, rust-gstreamer-check-sys-0.23.5-1.fc41, and 2 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-f504848417 FEDORA-2025-dad0c339e3 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-dad0c339e3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-dad0c339e3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-f504848417 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-f504848417 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-f504848417 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-f504848417 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-f504848417 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-f504848417 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-dad0c339e3 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-dad0c339e3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-dad0c339e3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-dad0c339e3 (rust-gstreamer-app-0.23.5-1.fc42, rust-gstreamer-app-sys-0.23.5-1.fc42, and 6 more) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-f504848417 (rust-gstreamer-app-0.23.5-1.fc41, rust-gstreamer-app-sys-0.23.5-1.fc41, and 6 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |