Bug 2344511
| Summary: | Review Request: f42-backgrounds - Fedora 42 default desktop background | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luya Tshimbalanga <luya_tfz> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | RELEASE_PENDING --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review, ppywlkiqletw |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | ngompa13:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://fedoraproject.org/wiki/Design | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Luya Tshimbalanga
2025-02-08 23:53:06 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8630937 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2344511-f42-backgrounds/fedora-rawhide-x86_64/08630937-f42-backgrounds/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes:
* Package follows Packaging Guidelines
* Package builds and installs
* Package licensing is correct
* One issue detected by rpmlint to fix:
> f42-backgrounds-kde.noarch: E: script-without-shebang /usr/share/wallpapers/F42/metadata.json
This should just be a plain file with 644 permissions. Please fix this on import.
Otherwise, this package is good to go, so...
PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/f42-backgrounds Currently, the background doesn't work in the XFCE desktop as it doesn't understand the new JPEG XL format. Also, the standard image viewer in XFCE doesn't understand JPEG XL. (In reply to Villy Kruse from comment #4) > Currently, the background doesn't work in the XFCE desktop as it doesn't > understand the new JPEG XL format. Also, the standard image viewer in XFCE > doesn't understand JPEG XL. Xfce should support it if "jxl-pixbuf-loader" is installed, since it hooks into gdk-pixbuf. (In reply to Neal Gompa from comment #5) > > Xfce should support it if "jxl-pixbuf-loader" is installed, since it hooks > into gdk-pixbuf. That is it. Then I suggest that "f42-backgrounds-base" should require"jxl-pixbuf-loader" as it doesn't work without it. (In reply to Villy Kruse from comment #6) > (In reply to Neal Gompa from comment #5) > > > > Xfce should support it if "jxl-pixbuf-loader" is installed, since it hooks > > into gdk-pixbuf. > > That is it. Then I suggest that "f42-backgrounds-base" should > require"jxl-pixbuf-loader" > as it doesn't work without it. Done: https://src.fedoraproject.org/rpms/f42-backgrounds/c/455c3ccf5bb206114b7fe753067af85815fc3b10 |