Bug 234563

Correct SRPM URL: 
http://www.webalice.it/musuruan/RPMS/reviews/tecnoballz-0.91-2.src.rpm

Looks good overal, however:

Must FIX:
---------
* This form of the cache scriptlets is no longer used: "
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
    %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
" instead the guidelines / scriptlets page now says: "
touch --no-create %{_datadir}/icons/hicolor || :
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
" Please change this to the new form.

* If you use sgid games, then you must make sure the game drops the additonal
  rights ASAP, see:
http://fedoraproject.org/wiki/SIGs/Games?action=show&redirect=Extras%2FSIGs%2FGames#head-367e7208aacfec8f8aff1b34c1795e43c0967ecd
  if you need help with this let me know.

(In reply to comment #2)
> * This form of the cache scriptlets is no longer used: "
> touch --no-create %{_datadir}/icons/hicolor || :
> if [ -x %{_bindir}/gtk-update-icon-cache ]; then
>     %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
> fi
> " instead the guidelines / scriptlets page now says: "
> touch --no-create %{_datadir}/icons/hicolor || :
> %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
> " Please change this to the new form.

OK.

> * If you use sgid games, then you must make sure the game drops the additonal
>   rights ASAP, see:
>
http://fedoraproject.org/wiki/SIGs/Games?action=show&redirect=Extras%2FSIGs%2FGames#head-367e7208aacfec8f8aff1b34c1795e43c0967ecd
>   if you need help with this let me know.

Yes, I need help. Thanks.

BTW, just to know, are there any other options to handle the highscore file that
don't require programming?

Created attachment 151379 [details]
PATCH: drop sgid rights ASAP

As promised, and to answer you're question no. with highscores there are 2
options, which both take modfication / programming in this case:
1) Use shared highscores and drop sgid asap
2) Use per user highscores in $HOME

Spec URL: http://www.webalice.it/musuruan/RPMS/reviews/tecnoballz.spec
SRPM URL: http://www.webalice.it/musuruan/RPMS/reviews/tecnoballz-0.91-3.src.rpm

Changelog
- added a patch by Hans de Goede to drop setgid privileges when not needed
- changed icon cache scriptles to be compliant with updated guidelines
- changed vendor to fedora in desktop-file-install

Erm, you messed up the %postun script (you lost the "touch"), once thats fixed
I'm ready to approve this.

(In reply to comment #6)
> Erm, you messed up the %postun script (you lost the "touch"), once thats fixed
> I'm ready to approve this.

Sorry for that.

Spec URL: http://www.webalice.it/musuruan/RPMS/reviews/tecnoballz.spec
SRPM URL: http://www.webalice.it/musuruan/RPMS/reviews/tecnoballz-0.91-4.src.rpm

Changelog:
- corrected silly error in the %%postun script

MUST:
=====
* rpmlint output is:
E: tecnoballz non-standard-executable-perm /usr/bin/tecnoballz 02755
This is "normal" for this package and can be ignored
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel x86_64
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
0 No duplicate files & Permissions
* %clean & macro usage OK
* Contains code and permissable content
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed
* .desktop file as required and properly installed

Approved!

New Package CVS Request
=======================
Package Name: tecnoballz
Short Description:  A Breakout like game
Owners: musuruan
Branches: FC-5 FC-6
InitialCC: musuruan

Andrea,

I missed this during review, but please change the summary from: "A Breakout
like game" to "A Brick Busting game" before importing as breakout is a trademark.

Hans, I will as you requested.

cvs request done with changed description.

BTW no need to put the owner also in InitialCC.

Built successfully. Closing.