Bug 2345946

Summary: Review Request: gnome-shell-rpm-generators - RPM generators for gnome-shell
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-02-15 23:43:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2342225    

Description Michel Lind 2025-02-15 23:20:43 UTC
Spec URL: https://salimma.fedorapeople.org/gnome-shell-rpm-generators.spec
SRPM URL: https://salimma.fedorapeople.org/gnome-shell-rpm-generators-1-1.fc43.src.rpm

Description:
RPM generators for gnome-shell.

Currently it generates:

```
Provides: gnome-shell-extension(UUID)
Requires: (gnome-shell(api) = VER1 or gnome-shell(api) = VER2 or ...)
```

Fedora Account System Username: salimma

Comment 1 Michel Lind 2025-02-15 23:20:46 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=129279682

Comment 2 Neal Gompa 2025-02-15 23:22:52 UTC
Review notes:

* Package builds and installs
* Package licensing is correct
* Package follows packaging guidelines
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 3 Michel Lind 2025-02-15 23:23:50 UTC
Tested rebuilding gnome-shell-extension-argos with this change

+%if 0%{?fedora} >= 42
+BuildRequires:  gnome-shell-rpm-generators
+%else
 Requires:       (gnome-shell >= 45.0 with gnome-shell < 48.0)
+%endif


Provides: gnome-shell-extension(argos.com) = 3^20240328gitbb59118 gnome-shell-extension-argos = 3^20240328gitbb59118-2.fc43
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: (gnome-shell(api) = 45 or gnome-shell(api) = 46 or gnome-shell(api) = 47)
Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILD/gnome-shell-extension-argos-3_20240328gitbb59118-build/BUILDROOT
Wrote: /builddir/build/RPMS/gnome-shell-extension-argos-3^20240328gitbb59118-2.fc43.noarch.rpm

michel in specs-for-review/gnome-shell-rpm-generators on  main [?] took 4m21s 
⬢ [fedora-packaging] ❯ rpm -qp --provides ./repo/results/fedora-rawhide-x86_64/gnome-shell-extension-argos-3^20240328gitbb59118-2.el10_0/gnome-shell-extension-argos-3^20240328gitbb59118-2.fc43.noarch.rpm
gnome-shell-extension(argos.com) = 3^20240328gitbb59118
gnome-shell-extension-argos = 3^20240328gitbb59118-2.fc43

michel in specs-for-review/gnome-shell-rpm-generators on  main [?] 
⬢ [fedora-packaging] ❯ rpm -qp --requires ./repo/results/fedora-rawhide-x86_64/gnome-shell-extension-argos-3^20240328gitbb59118-2.el10_0/gnome-shell-extension-argos-3^20240328gitbb59118-2.fc43.noarch.rpm
(gnome-shell(api) = 45 or gnome-shell(api) = 46 or gnome-shell(api) = 47)
rpmlib(CaretInVersions) <= 4.15.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1
rpmlib(RichDependencies) <= 4.12.0-1

Comment 4 Fedora Admin user for bugzilla script actions 2025-02-15 23:24:41 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-rpm-generators

Comment 5 Fedora Update System 2025-02-15 23:40:33 UTC
FEDORA-2025-46a008b01e (gnome-shell-rpm-generators-1-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-46a008b01e

Comment 6 Fedora Update System 2025-02-15 23:43:41 UTC
FEDORA-2025-46a008b01e (gnome-shell-rpm-generators-1-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2025-02-15 23:47:31 UTC
FEDORA-2025-ed30786dc2 (gnome-shell-rpm-generators-1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-ed30786dc2

Comment 8 Fedora Update System 2025-02-15 23:49:42 UTC
FEDORA-2025-ed30786dc2 (gnome-shell-rpm-generators-1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.