Bug 2346429

Summary:	Review Request: perl-Net-LibNFS - User-land NFS in Perl via libnfs
Product:	[Fedora] Fedora	Reporter:	Chris Adams <linux>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	NEW ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, xavier
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2346427, 2346428
Bug Blocks:

Description Chris Adams 2025-02-19 00:05:53 UTC

Spec URL: https://fedorapeople.org/~cmadams/perl-Net-LibNFS/perl-Net-LibNFS.spec
SRPM URL: https://fedorapeople.org/~cmadams/perl-Net-LibNFS/perl-Net-LibNFS-0.05-1.fc41.src.rpm
Description:
libnfs allows you to access NFS shares in user-space. Thus you can read &
write files via NFS even if you can’t (or just would rather not) mount(8)
them locally.

Fedora Account System Username: cmadams

Comment 1 Xavier Bachelot 2025-07-24 10:58:23 UTC

Hi Chris,

Some notes after a first look at this review.

- _fixperms macro uses chmod so BR: coreutils is missing

- in files section
"""
%dir %{perl_vendorarch}/auto/Net
%{perl_vendorarch}/auto/Net/LibNFS*
%dir %{perl_vendorarch}/Net
%{perl_vendorarch}/Net/LibNFS*
"""
  could be simplified to
"""
%{perl_vendorarch}/auto/Net/
%{perl_vendorarch}/Net/
"""

- It's is usually preferred to reference the tarball by module rather than by author.
  Source0 could be changed to use https://www.cpan.org/modules/by-module/Net/Net-LibNFS-%{version}.tar.gz

- Package fails to build for Rawhide and F42, but succeeds with F41
  Likely induced by gcc 15 but possibly also libnfs update from libnfs 5 to libnfs 6

Regards,
Xavier

Comment 2 Chris Adams 2025-07-25 21:07:42 UTC

The failure to build is actually an issue with newer perl, with a simple fix in an upstream github issue.

Added the BR:coreutils (which... is still debatable since chmod is pulled in by RPM itself). I left the %files alone; if a later version installed unexpected files outside, they'd be caught this way (similar to not just doing %{_bindir}/*).

Spec URL: https://fedorapeople.org/~cmadams/perl-Net-LibNFS/perl-Net-LibNFS.spec
SRPM URL: https://fedorapeople.org/~cmadams/perl-Net-LibNFS/perl-Net-LibNFS-0.05-2.fc41.src.rpm

Comment 3 Xavier Bachelot 2025-07-28 08:29:57 UTC

Still failing to build in mock against Rawhide, Here's a scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=135388300

libnfs needs at least an upstream patch applied, I will take care of that.
https://github.com/sahlberg/libnfs/commit/2cdfedaba379cbb512d3c203a1b9eae795f4fb23

But there's more to fix in Net::LibNFS

Comment 4 Xavier Bachelot 2025-07-28 09:35:57 UTC

libnfs in Rawhide is fixed and F42 update has been submitted:
https://bodhi.fedoraproject.org/updates/FEDORA-2025-8ca9cb3ee3

Comment 5 Chris Adams 2025-07-29 02:12:09 UTC

Thanks, I'll look more. I built it locally in mock fedora-rawhide to see a local log, then found the perl fix, then forgot to specify rawhide when I built again. Sigh...