Bug 2346778 (rust-audiopus_sys)

Summary: Review Request: rust-audiopus_sys - FFI-Binding to Opus
Product: [Fedora] Fedora Reporter: Marc-Andre Lureau <marcandre.lureau>
Component: Package ReviewAssignee: Cole Robinson <crobinso>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: crobinso, package-review
Target Milestone: ---Flags: crobinso: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/audiopus_sys
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-03-04 06:23:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2346781    
Attachments:
Description Flags
The .spec file difference from Copr build 8675807 to 8716354 none

Comment 1 Fedora Review Service 2025-02-20 15:53:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8675807
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2346778-rust-audiopus_sys/fedora-rawhide-x86_64/08675807-rust-audiopus_sys/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Cole Robinson 2025-03-01 19:24:40 UTC
This has install problems on rawhide:

# sudo yum install ./*.noarch.rpm
Updating and loading repositories:
Repositories loaded.
Failed to resolve the transaction:
Problem 1: conflicting requests
  - nothing provides (crate(bindgen/default) >= 0.58.0 with crate(bindgen/default) < 0.59.0~) needed by rust-audiopus_sys+bindgen-devel-0.2.2-1.fc43.noarch from @commandline
 Problem 2: package rust-audiopus_sys+generate_binding-devel-0.2.2-1.fc43.noarch from @commandline requires crate(audiopus_sys/bindgen) = 0.2.2, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(bindgen/default) >= 0.58.0 with crate(bindgen/default) < 0.59.0~) needed by rust-audiopus_sys+bindgen-devel-0.2.2-1.fc43.noarch from @commandline
You can try to add to command line:
  --skip-broken to skip uninstallable packages

Comment 4 Fedora Review Service 2025-03-02 06:46:17 UTC
Created attachment 2078508 [details]
The .spec file difference from Copr build 8675807 to 8716354

Comment 5 Fedora Review Service 2025-03-02 06:46:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8716354
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2346778-rust-audiopus_sys/fedora-rawhide-x86_64/08716354-rust-audiopus_sys/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Cole Robinson 2025-03-03 19:50:34 UTC
+ spec matches rust2rpm.toml output and looks ok: deleting bundled opus library and changing packaging to depend on distro provided version
+ builds on rawhide
+ installs on rawhide
+ content looks fine

setting fedora-review+

Comment 7 Fedora Admin user for bugzilla script actions 2025-03-04 06:11:15 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-audiopus_sys

Comment 8 Fedora Update System 2025-03-04 06:20:39 UTC
FEDORA-2025-28c63d50ab (rust-audiopus_sys-0.2.2-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-28c63d50ab

Comment 9 Fedora Update System 2025-03-04 06:23:52 UTC
FEDORA-2025-28c63d50ab (rust-audiopus_sys-0.2.2-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.