Bug 2346860

Summary: Review Request: rust-linicon-theme - Get the user's current icon the on Linux
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/linicon-theme
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-02-25 23:56:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2346766    
Bug Blocks: 2346861    

Description Davide Cavalca 2025-02-20 17:25:52 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-linicon-theme/rust-linicon-theme.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-linicon-theme/rust-linicon-theme-1.2.0-1.fc43.src.rpm

Description:
Get the user's current icon the on Linux.

Fedora Account System Username: dcavalca

Comment 1 Fedora Review Service 2025-02-20 17:27:22 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8676052
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2346860-rust-linicon-theme/fedora-rawhide-x86_64/08676052-rust-linicon-theme/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Davide Cavalca 2025-02-20 17:30:56 UTC
$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = [
  "Bump rust-ini to 0.18",
]

[tests]
run = ["none"]
comments = ["Tests are missing artifacts, and stil fail even with those"]

Comment 3 Michel Lind 2025-02-25 22:38:00 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MPL-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

## Review template (compat)

Compat package, looks identical to the existing rust-$crate. APPROVED

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard -R rust-$crate$ver` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Admin user for bugzilla script actions 2025-02-25 23:38:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-linicon-theme

Comment 5 Fedora Update System 2025-02-25 23:47:01 UTC
FEDORA-2025-c391550359 (rust-linicon-theme-1.2.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-c391550359

Comment 6 Fedora Update System 2025-02-25 23:56:48 UTC
FEDORA-2025-c391550359 (rust-linicon-theme-1.2.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.