Bug 234717 (spambayes)

Spec URL: http://tkmame.retrogames.com/fedora-extras/python-spambayes.spec
SRPM URL:
http://tkmame.retrogames.com/fedora-extras/python-spambayes-1.0.4-2.src.rpm

%changelog
* Thu Apr 05 2007 Christopher Stone <chris.stone> 1.0.4-2
- %%exclude pyo and pyc files from %%{_bindir}
- Add scriptlet to remove shebangs


Okay, added some stuff to remove the rpmlint warnings.  Still need to test this
out to make sure everything still works.

During byte compiling I get errors like this:

-----
  File "/usr/lib/python2.5/site-packages/spambayes/Corpus.py", line 81
SyntaxError: ('from __future__ imports must occur at the beginning of the file',
('/usr/lib/python2.5/site-packages/spambayes
/Corpus.py', 81, None, None))
-----

It might not be a problem, but I fixed it by removing the line that tries to
import __future__ since it is no longer needed. I added this line to the %prep
section:

-----
# Fixes warnings during byte compiling.
sed -i "s/from __future__ import generators//" spambayes/*.py
-----

I've tested it and it builds in mock on rawhide i386. I've also tested building
it on fc6 x86_64. No problems so far.

Spec URL: http://tkmame.retrogames.com/fedora-extras/python-spambayes.spec
SRPM URL:
http://tkmame.retrogames.com/fedora-extras/python-spambayes-1.0.4-3.src.rpm

%changelog
* Thu Apr 05 2007 Christopher Stone <chris.stone> 1.0.4-3
- Add patch to fix python2.5 errors

The package looks good to me, but I cannot assign the package to my self.
Shouldn't the package block FE_NEW?

Trond, did you get your bugzilla accounts sorted out?

fwiw, rpmlint is clean on both src.rpm and built .noarch rpm.  neat.

(In reply to comment #5)
> Trond, did you get your bugzilla accounts sorted out?

Indeed I did! Sorry for the slow progress. I will finish the review today.

Created attachment 153445 [details]
Complete review report.

Package looks good to me! APPROVED by Trond Danielsen.

New Package CVS Request
=======================
Package Name: python-spambayes
Short Description: Bayesian anti-spam filter
Owners: chris.stone
Branches: FC-5 FC-6 EL-5
InitialCC:

Before we add this, a question.

python-$name naming was originally intended to be used mainly for libraries, not
the leaf-node applications.
yum isn't called python-yum.
system-config-securitylevel is not called python-system-config-security level.

It might be best to name the Fedora package just plain "spambayes" because that
matches the upstream name, and that is what people would expect it be called
when they try to install it?

Yes, I added python- because I thought it was needed.  Updated version to change
name to just spambayes:

Spec URL: http://tkmame.retrogames.com/fedora-extras/spambayes.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/spambayes-1.0.4-3.src.rpm

%changelog
* Fri Apr 27 2007 Christopher Stone <chris.stone> 1.0.4-4
- Remove python from package name

New Package CVS Request
=======================
Package Name: spambayes
Short Description: Bayesian anti-spam filter
Owners: chris.stone
Branches: FC-5 FC-6 EL-5
InitialCC:

oops forgot to edit my copy&paste, fixed URL:

SRPM URL: http://tkmame.retrogames.com/fedora-extras/spambayes-1.0.4-4.src.rpm

(In reply to comment #11)
> Before we add this, a question.
> 
> python-$name naming was originally intended to be used mainly for libraries, not
> the leaf-node applications.
> yum isn't called python-yum.
> system-config-securitylevel is not called python-system-config-security level.
> 
> It might be best to name the Fedora package just plain "spambayes" because that
> matches the upstream name, and that is what people would expect it be called
> when they try to install it?
> 

Whops, sorry for not catching that during the review :(.

Built on all branches, thanks for the review!

Package Change Request
======================
Package Name: spambayes
New Branches: epel7
Owners: pghmcfc cicku

Git done (by process-git-requests).