Bug 234721
| Summary: | Review Request: sakura - A terminal emulator based on GTK+ and VTE | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Damien Durand <splinux25> |
| Component: | Package Review | Assignee: | Xavier Lamien <lxtnow> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lxtnow, mtasaka |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-09 17:38:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Damien Durand
2007-03-31 21:09:27 UTC
Two small issues: [trondd@localhost ~]$ rpmlint rpmbuild/RPMS/i386/sakura-* E: sakura non-standard-executable-perm /usr/share/pixmaps/terminal-tango.png 0555 E: sakura non-standard-executable-perm /usr/bin/sakura 0555 Fixed with a new rpm Spec URL: http://glive.tuxfamily.org/fedora/sakura/sakura.spec SRPM URL: http://glive.tuxfamily.org/fedora/sakura/sakura-1.1.4-2.src.rpm Well, You should add flags INSTALL="install -p" to your make install to keep timestamp on files, such as doc files, *.png files (which is included including in this package). ------ .desktop file ------ ** category: Application and X-fedora is deprecated and SHOULD be remove. can be fix by adding "-remove-category=" option ** .desktop file : no correct permission -> 0664 [SmootherFrOgZ@Helzeilerd ~]$ ll rpmbuild/SOURCES/sakura.desktop -rw-rw-r-- 1 SmootherFrOg lxtnow 271 Apr 6 09:47 rpmbuild/SOURCES/sakura.desktop can be fix by adding -mode 0644 option from desktop-file-install. ** scriptlets: %post update-desktop-database &> /dev/null ||: %postun update-desktop-database &> /dev/null ||: The use of above is only require when the desktop entry have a mime type key. and isn't the case. This scriptlet can be remove. Some notes:
* Timestamps
- Well, while the method 'INSTALL="%{__install} -p"' normally
works for makefile.in generated by GNU autotools,
for the types of makefiles which were created by developer
by his own way (like this package), it is very rare that
this method still works (and actually for this package
it does not work).
For the latter case, the packager has to check what are actually
done on install stage and fix some files appropriately.
Normally the package has to change the command like "cp" or
"install" appropriately (see the lines 119-148 of mobs.mk).
* Cflags
- And for makefiles generated by GNU autotools, fedora specific
compilation flags are normally passed correctly by %configure
macro (please check what %configure actually does),
however, again for the types of makefiles created by the developer's
own way, passing cflags has to be done with a special care
Actually
------------------------------------------
%build
./0 --prefix=/usr
make %{?_smp_mflags}
------------------------------------------
does not use fedora specific compilation flags (%optflags or
$RPM_BUILD_FLAGS). You have to use this flags _somehow_
* Desktop file
- Be careful on the each item on desktop file (e.g. is the
path for icon used correct? in the first place, does the
path have to be specified by full path?)
(In reply to comment #4) > $RPM_BUILD_FLAGS). $RPM_OPT_FLAGS, sorry ping ? re: ping ? no answer from the reporter until now I will close this bug as NOTABUG if no response is received within ONE WEEK. CLOSING. If someone want to maintain this package, please sumbit a new review request, Thank you. *** This bug has been marked as a duplicate of bug 496166 *** |