Bug 234789 (perl-Return-Value)

Summary:	Review Request: perl-Return-Value - Polymorphic Return Values
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <tcallawa>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	rc040203: fedora-review+ jwboyer: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-04-04 22:38:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	234791

Description Tom "spot" Callaway 2007-04-01 23:18:58 UTC

Spec URL: http://www.auroralinux.org/people/spot/review/perl-Return-Value.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/perl-Return-Value-1.302-1.src.rpm
Description: 
This module provides polymorphic return values with a simple API that should
get you what you're looking for in each context a return value is used in.

Comment 1 Ralf Corsepius 2007-04-02 05:06:28 UTC

Two minor issues:

1.

# rpmbuild ...
...
+ /usr/bin/perl Makefile.PL INSTALLDIRS=vendor
WARNING: LICENSE is not a known parameter.
...
=> This is a minor bug inside of Makefile.PL

Removing the line containing "LICENSE" would remove this warning.

2. 
...
t/perl-critic.....skipped
        all skipped: define PERL_TEST_CRITIC to run these tests
...
I'd recommend to change 
make test 
into
make test PERL_TEST_CRITIC=1

and to BR: perl(Test::Perl::Critic)

Nevertheless, I am approving this package.

APPROVED

Comment 2 Tom "spot" Callaway 2007-04-02 14:34:16 UTC

New Package CVS Request
=======================
Package Name: perl-Return-Value
Short Description: Polymorphic Return Values
Owners: tcallawa
Branches: FC-5 FC-6
InitialCC: fedora-perl-devel-list

Comment 3 Tom "spot" Callaway 2007-04-04 22:38:43 UTC

Built.