Bug 234791 (perl-Email-Send)
Summary: | Review Request: perl-Email-Send - Module for sending email | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
Component: | Package Review | Assignee: | Bernard Johnson <bjohnson> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | bjohnson:
fedora-review+
wtogami: fedora-cvs+ |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-04-25 20:37:22 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 234789, 234790 | ||
Bug Blocks: |
Description
Tom "spot" Callaway
2007-04-01 23:26:51 UTC
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Rpmlint output: None [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package is licensed with an open-source compatible license and meet other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL or Artistic [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is written in American English. [x] Spec file for the package is legible. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : d0640973bf0f01e5ad8fbd4c8b274005 MD5SUM upstream package: d0640973bf0f01e5ad8fbd4c8b274005 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: FC-6 / i386 [x] Package is not known to require ExcludeArch, OR: Arches excluded: Why: [!] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package is not relocatable. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: FC-6 / i386 [-] Package should compile and build into binary rpms on all supported architectures. Tested on: [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files are correct. [-] File based requires are sane. [x] Latest version is packaged. === Issues === 1. Missing BR: perl(Test::Pod), perl(Test::Pod::Coverage) for full test coverage. === Final Notes === 1. ================ *** APPROVED *** ================ pending fixing missing BR. Sorry, I typed the wrong review in here (this was for perl-Email-Date)... ignore this one. Proper review to follow. Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Rpmlint output: None [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package is licensed with an open-source compatible license and meet other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL or Artistic [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is written in American English. [x] Spec file for the package is legible. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 1f728eab1cf972c5bf4d9fa702397d75 MD5SUM upstream package: 1f728eab1cf972c5bf4d9fa702397d75 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: FC-6 / i386 [x] Package is not known to require ExcludeArch, OR: Arches excluded: Why: [!] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package is not relocatable. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: FC-6 / i386 [-] Package should compile and build into binary rpms on all supported architectures. Tested on: [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files are correct. [-] File based requires are sane. [x] Latest version is packaged. === Issues === 1. WARNING: LICENSE is not a known parameter. (during build) 2. Missing BR: perl(Mail::Internet), perl(MIME::Entity), perl(Test::Pod), perl(Test::Pod::Coverage), /usr/sbin/sendmail === Final Notes === 1. Please resubmit with fixes listed. New SPEC: http://www.auroralinux.org/people/spot/review/perl-Email-Send.spec New SRPM: http://www.auroralinux.org/people/spot/review/perl-Email-Send-2.185-2.fc7.src.rpm Fixes WARNING: LICENSE and adds missing BR. ================ *** APPROVED *** ================ New Package CVS Request ======================= Package Name: perl-Email-Send Short Description: Module for sending email Owners: tcallawa Branches: FC-5 FC-6 InitialCC: fedora-perl-devel-list Built. |